--browser opens up the browser for the command line - it is more difficult to spot errors than it should be.

rc eligible because it only changes test code.

Screenshots:

CommentFileSizeAuthor
#8 2583009-8.patch837 bytesalexpott
#6 2583009.6.patch959 bytesalexpott
#2 2583009-2.patch869 bytesalexpott
after-colours.png366.59 KBalexpott
before-no-colours.png294.82 KBalexpott
d8.browser.patch1.84 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2583009-2.patch869 bytes

bah - the perils of veering off a branch based workflow....

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

<3
This is truely a game changer.

The last submitted patch, d8.browser.patch, failed testing.

The last submitted patch, d8.browser.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2583009.6.patch959 bytes

Manual testing showed that this broke the simpletest form in seven... patch attached fixes it. The problem was cause because of the generic hover state css in tables.css. This patch will also fix simpletest output in themes which don't implement table striping with odd/even classes.

Tested with seven and run-tests.sh and everything is now looking great.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2583009.6.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Reviewed & tested by the community
FileSize
2583009-8.patch837 bytes

lol... use a branch alexpott.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Reviewed & tested by the community » Needs review

Why are there odd/even classes added to table rows when simpletest is run via the UI, but not from run-tests.sh?

The last submitted patch, 6: 2583009.6.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

The odd and even classes are added my classy compare table.html.twig in classy and system

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented

Makes sense. Adding review credit to @dawehner.

  • effulgentsia committed 74cd53e on 8.0.x 
    Issue #2583009 by alexpott, dawehner: --browser output from run-tests.sh...
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Reviewed & tested by the community » Fixed

Pushed to 8.0.x.

The last submitted patch, 6: 2583009.6.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 8: 2583009-8.patch, failed testing.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Needs work » Fixed

Last test ran after I pushed, so it failed. But earlier tests passed, so back to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.