D8 install should check MySQL version (Syntax error or access violation: 1115 Unknown character set: 'utf8mb4')

Which mysql versions are you using? (server / libmysqlclient?) And which version of drupal 8?

I'm getting the same error due to the MySQL server version installed but no notification said so. Had to look at the install requirements to see that it required 5.5.3 or higher. Testing with webhost Dreamhost and they have 5.1.56 as a standard so I requested to have the SQL database moved to their beta testing MySQL 5.6.

Drupal: 8.0.0-rc1

MySQL Server version: 5.1.56

MySQL 5.5.3 is the minium that ini_charset() could just force it to utf8mb4

Moving version back to 8.0.x which is where it will get fixed.

I updated the issue summary with details about the task.

I do not know if it is still necessary to have the client error code or if we could just replace it with the server error code. Once that is confirmed, then the appropriate patch can be written fairly trivially.

It is also possible to write a test if we want to mock Connection for the driver to return an error message and try to run the install task for the driver.

Changing component to mysql driver.

Hi. I've tried to make a patch for this issue.

Under what circumstances does the error in #7 appear? I think the problem is the server version rather than the libmysqlclient version? #7 used mysqlnd so the problem there was not libmysqlclient.

We already have some logic in the installer that makes it fall back to utf8, we should probably catch the mentioned exception and use that instead.

There are updated patch #15. Tested under Windows + MySQL 5.1.67.

Ah that's right, we need to check for both!

+++ b/core/lib/Drupal/Core/Database/Driver/mysql/Install/Tasks.php
@@ -71,7 +71,8 @@ protected function connect() {
+        || ($e->getCode() == 42000 && $e->errorInfo[1] == Connection::UNKNOWN_CHARSET)) {

Should we add a constant for SQLSTATE error code 42000? (Syntax error or access violation)

+++ b/core/lib/Drupal/Core/Database/Driver/mysql/Connection.php
@@ -34,6 +34,11 @@ class Connection extends DatabaseConnection {
+   * Error code for "Unknown character set" error.

Should we change this to "Driver-specific error code for "Unknown character set" error."?

see https://secure.php.net/manual/en/pdo.errorinfo.php

One more patch update. With help of @stefan.r.

Looks great to me! @Liam Morland or anyone else could you please manually test?

Thanks! Could we re-upload #18? This change would be out of scope here, it's fine to keep it hardcoded as this is about utf8mb4 support which is 5.5.3 always, and it'd need an @placeholder rather than a :placeholder.

Sure we can re-upload patch #18. But why we should leave minimal MySQL server version hardcoded? I think during Drupal 8 life cycle it won't be changed to higher version that will not reflect really minimal version.

Thanks! In case the minimum changes, the /whole/ message will need to be rewritten. "a version that supports utf8mb4, such as (new minimum version)", wouldn't be correct... so, RTBC'ing re-uploaded #18.

Seems it hasn't been re-uploaded yet, setting back to NW

Yeah, looks like it'll be better hardcoded. Re-uploading #18 and RTBCing according to #25.

+++ b/core/lib/Drupal/Core/Database/Driver/mysql/Install/Tasks.php
@@ -71,7 +71,8 @@ protected function connect() {
+        || ($e->getCode() == Connection::SQLSTATE_SYNTAX_ERROR && $e->errorInfo[1] == Connection::UNKNOWN_CHARSET)) {

I'm not sure if the line wrapping here is what is done in other places in core.

I looked at the coding standards to make sure, but there are no coding standards with regard to wrapping conditions on the next line so this technically does not need to be fixed.

#30 we do do it in a few places if you grep for ' ||', let's have a core committer it fix it on commit if necessary.

Looks good, thanks

Awesome, thanks a lot for this. I've hit this before, I think on DreamHost and it's a totally inscrutable problem.

Talked this over with the core committers, and we agreed that this is a viable RC target. It's a non-invasive fix, with a lot of impact for users.

Committed and pushed to 8.0.x. Thanks!