Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#2568595: Upgrade PHPUnit to latest 4.8.x changed vendor/bin/phpunit
from a symlink to shell script. The change was introduces because composer different results of different platforms. https://github.com/kocsismate/composer/blob/feature-bin-compat/src/Compo...
Proposed resolution
Revert the change.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | 2580527.patch | 507 bytes | webflo |
Comments
Comment #2
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #3
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #4
webflo CreditAttribution: webflo at UEBERBIT GmbH commentedComment #5
neclimdulbecause windows...
https://github.com/kocsismate/composer/blob/feature-bin-compat/src/Compo...
Locally applied and all is well.
Comment #6
dawehnerIts just sad how much time we wasted due to #1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead
Comment #7
hussainwebFWIW, I ran this on a Ubuntu VM running on Windows host. I have never had problems with symlinks earlier but maybe recent updates to composer changed something.
Also, the link you gave is some other repository. The link in the actual repo would be https://github.com/composer/composer/blob/master/src/Composer/Installer/.... I am curious as to why this happened.
Comment #8
hussainwebOkay, I see why this happened. I am only posting here for reference in case it happens to someone else (or if I forget).
It basically falls back to generating the proxy code if the symlink creation failed for some reason. I think it's functionally the same, but yes, let's keep things simple in core.
And yes, waiting on #1475510: Remove external dependencies from the core repo and let Composer manage the dependencies instead...
Comment #9
webchickCommitted and pushed to 8.0.x. Thanks a lot for the fast turnaround on this!
Comment #12
dawehnerStupid old bot.