Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
theme_indentation() still exists and we want to remove all theme functions before 8.0.0. #1982208: Replace indentation theme hook/indentation.html.twig with data attributes is the ideal outcome but is a tad risky just before release.
Proposed resolution
Remove theme_indentation() and just use the Twig template.
Remaining tasks
- Review
- Commit
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#3 | indentation-profiling-generate-settings.png | 37.16 KB | star-szr |
#2 | remove-2578567-2.patch | 1.67 KB | star-szr |
Comments
Comment #2
star-szrNumbers are looking very reasonable to me. This is 100 calls and also includes contextual_preprocess() for each template (@todo create issue to try to optimize that).
Scenario:
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=560d7dac0c098&...
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=560d7dac0c098&...
Comment #3
star-szrMissing screenshot for devel_generate settings:
Comment #4
star-szrAnd because it's worth mentioning: I had XDebug off, Twig debug off, render cache off.
Also, based on the xhprof breakdown most of the change seems to just be fluctuation from other things.
Comment #5
star-szrComment #6
lauriiiI was just wondering that these two has different classes. Should we change them to be the same or?
Comment #7
lauriiiIgnore last comment. Classes are the same in the template and in the theme function so they didn't change. RTBC for me
Comment #9
RainbowArrayRando migrate fail. Unrelated.
Comment #10
webchickCommitted and pushed to 8.0.x. Thanks!