Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.#2503047: Migrate the D6/D7 actions table to D8 has turned up a sneaky little bug -- node.schema.yml misdefines the configuration of the node_unpublish_by_keyword_action plugin. The result is that you can't save an action which uses this plugin -- it will always throw a config schema exception.
Proposed Resolution
Make node.schema.yml to match the plugin's configuration.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2578519-12.patch | 1.57 KB | phenaproxima |
| #12 | 2578519-12-FAIL.patch | 1.07 KB | phenaproxima |
| node-unpublish-action-schema.patch | 510 bytes | phenaproxima | |
Comments
Comment #2
phenaproximaComment #3
moshe weitzman CreditAttribution: moshe weitzman at Acquia commentedIn other words, virtually noone has tried to use since config schema went in. Migrating Actions is quite the luxury IMO.
Wait for green before commit.
Comment #6
phenaproximaI think PIFR knows that it's about to go extinct, so it's throwing a lot of tantrums. Restoring RTBC.
Comment #10
phenaproximaPIFR keeps experiencing a segmentation fault in the same test, which has absolutely nothing to do with this patch. Utter nonsense.
DrupalCI passes the patch with no problems. Seeing as how PIFR is about to be decommissioned, restoring RTBC.
Comment #11
webchickI believe this needs an upgrade path for existing sites, else their schema will get out of sync. See docs at https://www.drupal.org/node/2535316.
We also seem to be lacking any sort of test coverage for this plugin, because this obviously doesn't currently work at all with the incorrect name. :\
Comment #12
phenaproximaNow with a test!
Comment #17
Kazanir CreditAttribution: Kazanir commentedThis looks good; the test demonstrates that no one can have ever saved one of these (due to the schema mismatch) so we'd be adding an update function for actions that can't actually have ever existed.
Comment #18
webchickI believe we still need an upgrade path for existing sites, no?
Comment #19
alexpottWe don't need an upgrade patch - schema are static and parsed once the caches are flushed. The reason we didn't detect this in HEAD is that was nothing was using the schema. Test coverage is added - nice work.
Comment #20
alexpottCommitted 20fe22a and pushed to 8.0.x. Thanks!
Comment #22
webchickOh wow, didn't realize. Great!