Problem/Motivation

In User interface its recommended in Drupal not to use "Sorry" in the error message

Reference:

https://www.drupal.org/ui-standards -> Interface text ->Style -> bullet point number 5. (Attached the screen short)

Also the description says that "These guidelines are being applied in Drupal core." but its not.

Proposed resolution

Can we consider rephrasing the text something like. "Username or password Unrecognized. Have you forgotten your password?" For better user Interface.

User interface changes

Rephrase the text for better User interface and implement recommendation in core.

Beta Evaluation

Markup, which most of this is, is "unfrozen". This small amount of user-interface text is highly-visible in some cases, but the risk of patching this now is minimal.

CommentFileSizeAuthor
#33 d7-sorry_in_user_facing-2576037-23-33.patch9.49 KBsdstyles
#23 interdiff-17-23.txt1.64 KBsdstyles
#23 sorry_in_user_facing-2576037-23.patch12.42 KBsdstyles
#17 interdiff-2576037-14-17.txt1.49 KBunqunq
#17 sorry_in_user_facing-2576037-17.patch12.4 KBunqunq
#14 interdiff-13-14.txt1.3 KBmartins.kajins
#14 sorry_in_user_facing-2576037-14.patch10.71 KBmartins.kajins
#13 Screen Shot 2015-09-30 at 18.22.15.png188.92 KBunqunq
#13 interdiff-2576037.txt9.42 KBunqunq
#13 sorry_in_user_facing-2576037-13.patch9.42 KBunqunq
#10 d8_core-User_interface_standards-2576037-9-d8.patch3.36 KBer.manojsharma
#6 d8_core-User_interface_standards-2576037-5-d8.patch1.15 KBer.manojsharma
screenshot-www drupal org 2015-09-28 12-49-30.png284.01 KBDevaraj johnson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devaraj johnson created an issue. See original summary.

Devaraj johnson’s picture

Devaraj johnson CreditAttribution: Devaraj johnson commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Rephrase the error message for better user interface in user login page » "Sorry" in user-facing errors violates the User Interface Standards
Version: 7.39 » 8.0.x-dev
Component: user interface text » base system
Issue tags: +Needs backport to D7

"Sorry" is used elsewhere in user-facing error messages, so I changed the component to "base system".

Drupal 8 is the same thing, so I have moved this to the Drupal 8 queue according to the backport policy.

er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
Assigned: Unassigned » er.manojsharma
er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
Status: Active » Needs review

Please review my patch. Do we have to remove Sorry keyword from all files like Sorry, too many failed login attempts from your IP address.. etc.

er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
FileSize
d8_core-User_interface_standards-2576037-5-d8.patch1.15 KB

attached the patch file

Status: Needs review » Needs work

The last submitted patch, 6: d8_core-User_interface_standards-2576037-5-d8.patch, failed testing.

The last submitted patch, 6: d8_core-User_interface_standards-2576037-5-d8.patch, failed testing.

Status: Needs work » Needs review

snehi queued 6: d8_core-User_interface_standards-2576037-5-d8.patch for re-testing.

er.manojsharma’s picture

er.manojsharma CreditAttribution: er.manojsharma at Publicis Sapient for Publicis Sapient commented
FileSize
d8_core-User_interface_standards-2576037-9-d8.patch3.36 KB

Please review updated patch

The last submitted patch, 6: d8_core-User_interface_standards-2576037-5-d8.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: +Novice
unqunq’s picture

unqunq CreditAttribution: unqunq commented
FileSize
sorry_in_user_facing-2576037-13.patch9.42 KB
interdiff-2576037.txt9.42 KB
Screen Shot 2015-09-30 at 18.22.15.png188.92 KB

I found a few more and removed the text. I left unmodified a few more because I am not sure if I should change them or not.

martins.kajins’s picture

martins.kajins CreditAttribution: martins.kajins at Wunder commented
FileSize
sorry_in_user_facing-2576037-14.patch10.71 KB
interdiff-13-14.txt1.3 KB

Updated #13 patch with two more changes

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

Cool! At the time we avoided the "front-facing" parts but I am happy to fix this now.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work

There are two more in the quickedit module's JavaScript that should have this change. In those cases "Sorry!" should perhaps be "Error!".

unqunq’s picture

unqunq CreditAttribution: unqunq commented
FileSize
sorry_in_user_facing-2576037-17.patch12.4 KB
interdiff-2576037-14-17.txt1.49 KB

Added the last two from quickedit module.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented 
+++ b/core/modules/quickedit/js/models/EntityModel.js
@@ -410,7 +410,7 @@
-                Drupal.quickedit.util.networkErrorModal(Drupal.t('Sorry!'), message);
+                Drupal.quickedit.util.networkErrorModal(Drupal.t('Error!'), message);

+++ b/core/modules/quickedit/js/util.js
@@ -125,7 +125,7 @@
-          Drupal.quickedit.util.networkErrorModal(Drupal.t('Sorry!'), message);
+          Drupal.quickedit.util.networkErrorModal(Drupal.t('Error!'), message);

This should then become something like Network problem.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

Ok, lets do that.

The last submitted patch, 14: sorry_in_user_facing-2576037-14.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 17: sorry_in_user_facing-2576037-17.patch, failed testing.

sdstyles’s picture

sdstyles CreditAttribution: sdstyles at FFW commented
Status: Needs work » Needs review
FileSize
sorry_in_user_facing-2576037-23.patch12.42 KB
interdiff-17-23.txt1.64 KB

Changed according #19

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes

#23 removes all user-facing "sorry"s. I read over the patch and found no problems with it. I manually tested the bad password error and it looks fine. Could someone else give the patch a thorough read and mark this RTBC?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented
Status: Needs review » Reviewed & tested by the community

unqunq queued 17: sorry_in_user_facing-2576037-17.patch for re-testing.

The last submitted patch, 17: sorry_in_user_facing-2576037-17.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Version: 8.0.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

As a Canadian, I am only committing this under extreme duress.

Crying beaver and Canada flag

:P

Committed and pushed to 8.0.x. Sniff. ;)

Back to 7.x.

  • webchick committed 0e4c0f3 on 8.0.x 
    Issue #2576037 by unqunq, er.manojsharma, sdstyles, martins.kajins,...
Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

Hah! duress, fascinating :) Learning new words every day.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

@Bojhan "Duress" is fun, but "sorry" is the hardest word.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Issue tags: +JavaScript
sdstyles’s picture

sdstyles CreditAttribution: sdstyles at FFW commented
Status: Patch (to be ported) » Needs review
FileSize
d7-sorry_in_user_facing-2576037-23-33.patch9.49 KB

Ported patch to Drupal 7.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented

I'm not sure how much of this we can backport given https://www.drupal.org/node/1527558 - at least we'd probably want to leave out end-user-facing strings and error messages.

cilefen’s picture

cilefen CreditAttribution: cilefen commented

...we'd probably want to leave out end-user-facing strings and error messages

That is pretty much all this issue is, so is this a "won't fix"?

Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented
Status: Needs review » Closed (won't fix)

Yup, pretty much.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein as a volunteer commented
Version: 7.x-dev » 8.0.x-dev
Status: Closed (won't fix) » Fixed
Issue tags: -Needs backport to D7

Yeah, guess so. The IP address "has been banned" message isn't even translated so technically that could certainly be changed, but not sure anyone really cares much about that one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.