Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
- #2368987: Move internal page caching to a module to avoid relying on config get on runtime split off the Page Cache into a separate
page_cache
module, but did not add aMAINTAINERS.txt
nor a component. - #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) added the
dynamic_page_cache
module, aMAINTAINERS.txt
entry was also created, but no component was added.
Proposed resolution
- Add
page_cache
MAINTAINERS.txt
entry. - Add
page_cache.module
component. - Add
dynamic_page_cache.module
component.
Remaining tasks
TBD
Comment | File | Size | Author |
---|---|---|---|
#13 | 2575549-13.patch | 474 bytes | Wim Leers |
Comments
Comment #2
Wim LeersWe need this done so that people can actually report issues to the right components, and it's possible for maintainers to find these issues.
Comment #3
xjmAs a docs-only issue, this also can happen anytime, also.
Needs patch and review. :)
Comment #4
Wim LeersOh, great!
Comment #5
Wim LeersComment #6
Wim LeersComment #7
Fabianx CreditAttribution: Fabianx as a volunteer commentedI am happy to volunteer as page cache maintainer, too.
Maybe we also want znerol in there?
Comment #8
Wim Leers#7: Pinged znerol on IRC.
Comment #9
catchComment #10
Wim LeersSo, shall we add Fabianx to MAINTAINERS.txt for the Page Cache module then?
Comment #11
Wim Leers.
Comment #12
znerol CreditAttribution: znerol commentedLate pong, I'm okay with co-maintaining it.
Comment #13
Wim LeersAwesome! Thank you :)
Assigning to Dries; needs either to be committed by Dries or an explicit approval comment from him here.
Comment #14
Wim LeersSomebody already the components :) Thank you, anonymous person!
Reducing issue scope accordingly.
Comment #15
xjmPer #2635844: Committers may add subsystem maintainers, any committer can now sign off on this change. This looks great to me!
Since this will be @znerol's first MAINTAINERS.txt entry -- congrats! And can you confirm that you are comfortable with the maintainer role outlined in the Drupal core governance policy and the specific subsystem maintainer responsibilities for this module? Thanks!
Comment #16
catchJust +1ing this since this is partly a split out of the cache subsystem which I'm listed on.
Comment #17
znerol CreditAttribution: znerol commented@xjm I confirm.
Comment #18
Wim LeersComment #21
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!
Comment #22
Wim LeersThanks! Could you also add znerol to the "Assigned" dropdown's options?
Comment #23
catchDone!
Comment #24
Wim LeersThanks :)