Remove string cast of EntityType::getLabel() and getGroupLabel()

+++ b/core/lib/Drupal/Core/Entity/EntityType.php
@@ -696,7 +696,7 @@ public function getDataTable() {
   public function getLabel() {
-    return (string) $this->label;
+    return $this->label;
   }
 
   /**
@@ -733,7 +733,7 @@ public function getGroup() {

@@ -733,7 +733,7 @@ public function getGroup() {
    * {@inheritdoc}
    */
   public function getGroupLabel() {
-    return !empty($this->group_label) ? (string) $this->group_label : $this->t('Other', array(), array('context' => 'Entity type group'));
+    return !empty($this->group_label) ? $this->group_label : $this->t('Other', array(), array('context' => 'Entity type group'));
   }
 

Let's ensure our test coverage has the additional logic on top of it.

This also removes 1 of the 3 (!!!) remaining actual translate calls* on the frontpage

\o/

1. +++ b/core/tests/Drupal/Tests/Core/Entity/EntityTypeTest.php
   @@ -284,6 +286,44 @@ public function testId() {
   +  public function testgetLabel() {
   ...
   +  public function testgetGroupLabel() {
   

   Nitpick: testget -> testGet

2. +++ b/core/tests/Drupal/Tests/Core/Entity/EntityTypeTest.php
   @@ -284,6 +286,44 @@ public function testId() {
   +    $string_translation = $this->getMock(TranslationInterface::class);
   +    $string_translation->expects($this->atLeastOnce())
   +      ->method('translate')
   +      ->with('Other', array(), array('context' => 'Entity type group'))
   +      ->willReturn($default_label);
   

   I'd have used a SafeString object, but well, its a choice of everyone

Thank you!

Committed 3e59ace and pushed to 8.0.x. Thanks!

Reducing the number of times things are translated is a key performance concern.