file_check_directory actively does a drupal_set_message('Directory Created') and drupal_set_message('Directory permissions modified'). The average end user could care less about these successful operations and are oft times confused by it. This patch removes the DSM on success and adds a watchdog to the error case of failed directory creation... I would almost say it is worth while to even remove the form_set_errors from this function and have the calling code deal with error reporting to end users.

CommentFileSizeAuthor
file_check_directory-verbosity.patch1.67 KBdopry
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ricflomag’s picture

ricflomag CreditAttribution: ricflomag commented

Not only this is a good idea so that the average user does not get confused, but there is also a moderate security risk, because the full path to the directory is displayed on screen.

Should this patch be backported to 5.x and 6.x too ?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review

This is a patch.

Would be nice for getting rid of the dozens of messages that show up when running all tests as well.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

I agree. Committed to CVS HEAD.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.