Fix 'Drupal.WhiteSpace.OpenBracketSpacing' coding standard

As agreed between the mentors at Drupalcon, according to issues to avoid for novices, I am untagging this issue as "Beginner". This issue contains changes across a very wide range of files and might create too many other patches to need to be rerolled at this particular time. This patch has an automated way to be rerolled later so better to implement it after Drupalcon.

Updated issue summary to reflect how things actually work now.

This patch is the result of fixing errors with phpcbf.

I'm not sure I agree with the sniffer on some of these... For instance anonymous functions look funky when you remove the initial whitespace after the brace, as in:

-        array_map(function ($entity) { return $entity->getConfigDependencyName(); }, $affected_dependencies[$dependency_type]),
+        array_map(function ($entity) {return $entity->getConfigDependencyName(); }, $affected_dependencies[$dependency_type]),

Yes, you shouldn't run the fixer on one single rule in this case. Other Drupal fixer rules would kick the closure contents to the next line, then it looks more sane.

Yes, I understand about them being 'uneven.' :-) The matching change would happen in #2572787: Fix 'Drupal.WhiteSpace.CloseBracketSpacing' coding standard

Just that I like the whitespace in the anonymous function. Or perhaps we should have a standard about putting a new line after it and indenting. A bit out of scope for this issue, though.

+++ b/core/modules/comment/src/Tests/CommentNonNodeTest.php
@@ -156,7 +156,7 @@ function postComment(EntityInterface $entity, $comment, $subject = '', $contact
     // Get comment.
-    if ($contact !== TRUE) { // If true then attempting to find error message.
+    if ($contact !== TRUE) {// If true then attempting to find error message.
       if ($subject) {

Hmm. Maybe not. This looks more wrong than the anonymous function.

This sniff needs work or we need to add other sniffs that don't remove sensible spaces from anonymous functions.

Fixed sniff in 8.4.x.

+++ b/core/lib/Drupal/Core/Config/ConfigManager.php
@@ -452,7 +452,7 @@ protected function callOnDependencyRemoval(ConfigEntityInterface $entity, array
-        array_map(function ($entity) { return $entity->getConfigDependencyName(); }, $affected_dependencies[$dependency_type]),
+        array_map(function ($entity) {return $entity->getConfigDependencyName(); }, $affected_dependencies[$dependency_type]),

As me and alexpott said: this fix is wrong. Either we need to include other sniffs here that push this in a correct way to the next line or we need to exclude this file from being checked with PHPCS. Same for the other anonymous function changes in this patch.

@klausi, @alexpott why only for anonymous function?
I think there are two cases like you pointed:

1. +++ b/core/modules/ckeditor/src/Plugin/CKEditorPlugin/StylesCombo.php
   @@ -101,7 +101,7 @@ public function validateStylesValue(array $element, FormStateInterface $form_sta
   -      $style_names = array_map(function ($style) { return $style['name']; }, $styles_setting);
   +      $style_names = array_map(function ($style) {return $style['name']; }, $styles_setting);
   

   anonymous inline function

2. +++ b/core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php
   @@ -82,7 +82,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
   -  public function hasExtraOptions() { return TRUE; }
   +  public function hasExtraOptions() {return TRUE; }
   

   other inline functions

New rerolled patch.
The patch includes fixes for inline function issues.
I've moved return statement to the new line.
Additionaly there are fixes of existing cases with anonymous function like
function() {return $value;}
from core

Looks good to me.
No cs issues.
Changes only relate to the targeted sniff.
git diff --staged --color-words doesn't show code modifications except phpcs.xml.dist.

Committed/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!