Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/tour/src/TourViewBuilder.php:              '#children' => t('!tour_item of !total', array('!tour_item' => $index + 1, '!total' => $count)),

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

thewilkybarkid’s picture

Assigned: Unassigned » thewilkybarkid
thewilkybarkid’s picture

Assigned: thewilkybarkid » Unassigned
Status: Active » Needs review
FileSize
727 bytes
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

It is a simple number

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5742806 and pushed to 8.0.x. Thanks!

  • alexpott committed 5742806 on 8.0.x
    Issue #2572019 by thewilkybarkid: Remove !placeholder in TourViewBuilder
    

Status: Fixed » Needs work

The last submitted patch, 3: remove_placeholder_in-2572019-3.patch, failed testing.

nevergone’s picture

Status: Needs work » Fixed

Already committed.
Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.