Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only
modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php: $form_state->setError($element['title'], t('!name field is required.', array('!name' => $element['title']['#title'])));
Proposed resolution
Remaining tasks
Agree that removing HTML support makes sense.
User interface changes
None
API changes
Date format strings no longer support adding HTML using the \ escape character.
Data model changes
None
Beta phase evaluation
Issue category | Bug because at the moment date formats support HTML but it is escaped |
---|---|
Issue priority | Major because part of the critical to remove !placeholder |
Disruption | Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this. |
Comment | File | Size | Author |
---|---|---|---|
#6 | link-text-required.png | 2.51 KB | pfrenssen |
#2 | 2571949-2.patch | 1.03 KB | swentel |
Comments
Comment #2
swentel CreditAttribution: swentel commentedComment #3
angel.hComment #4
angel.hOpps, wrong issue! Unassigning myself.
Comment #5
pfrenssenGoing to review.
Comment #6
pfrenssenLooking good. I tested this in the UI, and it works as expected:
I also scanned the whole Link module for exclamation marks, and this is the only instance of it being used as a placeholder.
Comment #7
pfrenssenLooking good. I tested this in the UI, and it works as expected:
I also scanned the whole Link module for exclamation marks, and this is the only instance of it being used as a placeholder.
Comment #8
lauriiiHere fits the previous line. Can be fixed on the commit
Comment #9
alexpottCommitted d0fd5b1 and pushed to 8.0.x. Thanks!
Comment #12
dawehnerYeah this is actually fixed, buh PIFR.