Follow-up to #2571923: Remove HTML support from date formats and replace remaining !placeholder for aggregator

Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/book/src/BookManager.php:        '#description' => $this->t('The parent page in the book. The maximum depth for a book and all child pages is !maxdepth. Some pages in the selected book may not be available as parents if selecting them would exceed this limit.', a$ray('!maxdepth' => static::BOOK_MAX_DEPTH)),

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
CommentFileSizeAuthor
#2 2571937_1.patch1.22 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

chx’s picture

chx CreditAttribution: chx commented
Status: Active » Needs review
FileSize
2571937_1.patch1.22 KB

This must have been some micro optimization approximately one billion years ago.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

This is just perfect! I'm really curious indeed how this ever went in.

chx’s picture

chx CreditAttribution: chx commented

I can tell you: if it didn't need escaping why escape it? That was the logic, perfectly valid at the time. It's not even microoptimization if avoiding a performance hit, no matter how miniscule, does not take effort and does not add complexity.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed db10fff and pushed to 8.0.x. Thanks!

  • alexpott committed db10fff on 8.0.x 
    Issue #2571937 by chx: Remove !placeholder in BookManager

Status: Fixed » Needs work

The last submitted patch, 2: 2571937_1.patch, failed testing.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Fixed

Bot timing is awful.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.