Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/aggregator/src/Entity/Feed.php:      ->setDescription(t("The parent website's description that comes from the !description element in the feed.", array('!description' => '<description>')));

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
CommentFileSizeAuthor
#2 remove_html_support-2571923-2.patch855 bytesnevergone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

nevergone’s picture

nevergone CreditAttribution: nevergone commented
Issue summary: View changes
Status: Active » Needs review
FileSize
remove_html_support-2571923-2.patch855 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/aggregator/src/Entity/Feed.php
@@ -218,7 +218,7 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
-      ->setDescription(t("The parent website's description that comes from the !description element in the feed.", array('!description' => '<description>')));
+      ->setDescription(t("The parent website's description that comes from the @description element in the feed.", array('@description' => '<description>')));

Ah this is perfect. We want to escape the thing here!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed f629123 and pushed to 8.0.x. Thanks!

  • alexpott committed f629123 on 8.0.x 
    Issue #2571923 by nevergone: Remove HTML support from date formats and...

Status: Fixed » Needs work

The last submitted patch, 2: remove_html_support-2571923-2.patch, failed testing.

nevergone’s picture

nevergone CreditAttribution: nevergone commented
Status: Needs work » Fixed

Already committed.
Closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.