Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
CommentItem::mainPropertyName
is not overridden, so returns 'value'
, but 'value'
is not a valid property and trying to obtain its value throws
Uncaught PHP Exception InvalidArgumentException: "Property value is unknown."
Proposed resolution
Override CommentItem::mainPropertyName
and return 'cid'
.
Remaining tasks
Review.
User interface changes
None.
API changes
None.
Data model changes
None.
Beta phase evaluation
Issue category | Bug because the main property cannot be a non-existent property. |
---|---|
Issue priority | Normal because it doesn't affect sites directly, but API users. |
Disruption | Non disruptive at all. |
Comment | File | Size | Author |
---|---|---|---|
#8 | 2569465-8.patch | 1.25 KB | penyaskito |
Comments
Comment #2
penyaskitoComment #3
Gábor HojtsyComment #4
penyaskitoThis may be enough.
Comment #5
penyaskitoAdded beta eval. I think this is a bug, not a task.
Comment #6
penyaskitoComment #7
larowlanThe main property should be status, the other properties are essentially computed
Thanks
Comment #8
penyaskitoOops, thanks. No interdiff, the patch is trivial.
Comment #9
penyaskitoTagging as quickfix.
Comment #10
larowlanThanks again
Comment #13
penyaskitoBack to RTBC.
Comment #14
alexpottCommitted 9d11fa4 and pushed to 8.0.x. Thanks!
Comment #16
penyaskitoAwesome, thanks!