Problem/Motivation

CommentItem::mainPropertyName is not overridden, so returns 'value', but 'value' is not a valid property and trying to obtain its value throws

Uncaught PHP Exception InvalidArgumentException: "Property value is unknown."

Proposed resolution

Override CommentItem::mainPropertyName and return 'cid'.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because the main property cannot be a non-existent property.
Issue priority Normal because it doesn't affect sites directly, but API users.
Disruption Non disruptive at all.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

Status: Active » Needs review
FileSize
716 bytes
Gábor Hojtsy’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests
penyaskito’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
1.25 KB

This may be enough.

penyaskito’s picture

Category: Task » Bug report
Issue summary: View changes

Added beta eval. I think this is a bug, not a task.

penyaskito’s picture

Issue summary: View changes
larowlan’s picture

Status: Needs review » Needs work

The main property should be status, the other properties are essentially computed
Thanks

penyaskito’s picture

Status: Needs work » Needs review
FileSize
1.25 KB

Oops, thanks. No interdiff, the patch is trivial.

penyaskito’s picture

Issue tags: +Quickfix

Tagging as quickfix.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Thanks again

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 2569465-8.patch, failed testing.

Status: Needs work » Needs review

penyaskito queued 8: 2569465-8.patch for re-testing.

penyaskito’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9d11fa4 and pushed to 8.0.x. Thanks!

  • alexpott committed 9d11fa4 on 8.0.x
    Issue #2569465 by penyaskito: CommentItem must override mainPropertyName...
penyaskito’s picture

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.