Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only
theme_system_modules_details()
and template_preprocess_system_themes_page()
use !placeholder
.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | 2568609-2.patch | 3.25 KB | alexpott |
Comments
Comment #2
alexpottI might have gone a little bit further than necessary but if we're going to touch the lines like
'!module-list' => implode(', ', $module['#required_by'])
I think we should swap to using the new comma list item list since this is semantically correct and rendering produces a safe string.Comment #3
dawehnerOpened up #2568797: Add \Drupal::renderer() but document how and when it should be used after seeing that and agreeing that for now its the besser choice.
On the longrun you would better put that entire theme function into a template right? In there it would also be MUCH faster!
Comment #5
catchCommitted/pushed to 8.0.x, thanks!
Comment #6
xjmThat's kinda what I was hoping we'd do in this issue... followup?
Also, I would really have expected manual testing with screenshots for this change. @alexpott says he tested it manually in Stark and Bartik; no screenshots available though.
Comment #7
dawehnerThere we go, here is a follow up: #2568935: Convert theme_system_modules_details() to a template