Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
_system_is_incompatible() was last used in Drupal 6.x releases and has not been called anywhere in Drupal core since #229129: System module page *seriously* broken was committed in 2008.
Comment | File | Size | Author |
---|---|---|---|
#2 | remove_system_is_incompatible-1.patch | 1.29 KB | Antti J. Salminen |
remove_system_is_incompatible.patch | 1.42 KB | Antti J. Salminen | |
Comments
Comment #2
Antti J. Salminen CreditAttribution: Antti J. Salminen as a volunteer commentedLet's try again... had an extraneous newline removal in the patch.
Comment #3
chx CreditAttribution: chx commentedLooks good, thanks for catching this! Just out of sheer curiosity, do we have a test module for incompatible PHP versions?
Comment #4
xjmNice catch. Normally we'd want a change record, and during the beta we'd want to deprecate instead of removing the function, but given this is prefixed by an underscore and so obsolete, I don't think it's necessary in this case.
@chx, for tests in D8, there's SystemRequirementsTest.
Committed and pushed to 8.0.x. Thanks!
Comment #6
chx CreditAttribution: chx commentedNope, we do not have a test like what I asked we have DependencyTest::testIncompatibleCoreVersionDependency but not testIncompatiblePhpVersionDependency . Oh well.
Comment #7
Antti J. Salminen CreditAttribution: Antti J. Salminen as a volunteer commentedI created an issue for the test chx suggested and started on it: #2567861: Add test for enabling modules with incompatible PHP version dependency