Somehow Classy's page template ended up with two highlighted regions. It might have been around this issue #2470807: Rename the default "Messages" region for all themes to "Highlighted" but I don't see a direct cause there. I think maybe the messages region was renamed highlighted, but there was already a highlighted region? No idea why the System template didn't have it then.
One a scale of 1 to WTF ... well, it aint closer to 1.
We should also check the other page templates to make sure we didn't make a similar mistake.
In the initial patch I removed the second one, which keeps highlighted in the same place as in the System template.
Comment | File | Size | Author |
---|---|---|---|
removeduphighlighted.patch | 471 bytes | davidhernandez | |
Comments
Comment #2
lauriiiBoth Bartik and Seven override Classys page.html.twig template so there is no potential visual changes in them. Also having highlight region in the same place as in System module makes sense.
Comment #3
davidhernandezI also looked at the install and maintenance pages and didn't see any duplicates there.
Comment #4
alexpottCommitted 9822652 and pushed to 8.0.x. Thanks!
I think we can remove the blank line here in both classy and system's template but just in case not fixing on commit - it's a nice novice followup.
Comment #6
davidhernandezI think we can forgo the follow up because the title conversion issue will delete them from both templates, since that space is right before the title prefix.
#2476947: Convert "title" page element into a block
Comment #7
davidhernandezoops
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commented--- Why branch switches? I did not do it :) --
The documentation of Regions still duplicate highlighted
Add info:
In 7 themes used both variants
In 8 themes used only "page.highlighted: Items for the highlighted region."
In other themes used only "page.highlighted: Items for the highlighted content region."
Comment #10
davidhernandezI don't know what you are asking about the branch switch. No one switched branches, and this issue was fixed a long tim ago.
For the documentation mistake, please open a new issue.