[PHP 7 Compatibility] case: feeds_tamper_default_value_callback function [#2567431]

Inside:
/plugins/default_value.inc

New in PHP7:

Function parameters with duplicate name are not allowed anymore. Definitions like “function foo($x,$x) {}” will lead to compile time error.

As it in fact happens under PHP 7 due to this:

function feeds_tamper_default_value_callback($source, $item_key, $element_key, &$field, $settings, $source) {
  // Setting a default value.
  if (!empty($settings['only_if_empty']) && !$field) {
    $field = $settings['default_value'];
  }
  elseif (empty($settings['only_if_empty'])) {
    $field = $settings['default_value'];
  }
}

As a quick but not fully tested fix I change the function parameters to this:

function feeds_tamper_default_value_callback($source, $item_key, $element_key, &$field, $settings, $source_2) {
..
}

Comment	File	Size	Author
#2	feeds_tamper-fix-params-default-value-callback-2567431-2-7.x.patch	631 bytes	lexbritvin
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 September 2015 at 11:39

W.M. created an issue. See original summary.

Comment #2

lexbritvin CreditAttribution: lexbritvin commented 6 December 2015 at 20:55

Status:

Active

» Needs review

File	Size
feeds_tamper-fix-params-default-value-callback-2567431-2-7.x.patch	631 bytes

Hello!

Having the same issue on PHP7 using php7.0-fpm.

According to other tamper plugins, seems like there is a mistake in parameters, it's not only PHP7 compatibility issue - the 1st parameter $source should be $result.
Simple patch fixes the problem.

Comment #3

15 December 2015 at 04:51

twistor committed e310053 on 7.x-1.x authored by LexBritvin

Issue #2567431 by LexBritvin: [PHP 7 Compatibility] case:...

Comment #4

twistor CreditAttribution: twistor as a volunteer commented 15 December 2015 at 04:52

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Needs review	» Fixed

Comment #5

29 December 2015 at 04:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #6

aminorking CreditAttribution: aminorking commented 11 November 2016 at 16:14

Is it possible to get a stable release soon? Would be great to have a php 7 compatible recommended release. Many thanks.

Comment #7

W.M. CreditAttribution: W.M. commented 19 January 2017 at 18:03

Kindly release a new stable release with the above patch, thank you.

Comment #8

mausolos CreditAttribution: mausolos commented 22 February 2017 at 20:26

Bumping for "please release new stable release with the above patch" (and thank you, of course).

Comment #9

jay-dee-ess CreditAttribution: jay-dee-ess as a volunteer commented 1 May 2017 at 21:38

Agree with #6, 7 and 8.

Comment #10

acke CreditAttribution: acke at Happiness commented 2 May 2017 at 12:10

It would be appreciated with a stable PHP 7 compatible release.

Comment #11

Kris77 CreditAttribution: Kris77 commented 8 May 2017 at 19:50

It work for me too with php 7.

Thanks

Comment #12

grougy CreditAttribution: grougy as a volunteer commented 24 May 2017 at 16:24

Works for me too with PHP 7.0.14 x64

Comment #13

fonant CreditAttribution: fonant at Fonant Ltd commented 17 July 2017 at 16:04

Confirming that this patch fixes the fatal error when using PHP 7. Would be good to see a new stable release...

Comment #14

maxplus CreditAttribution: maxplus commented 13 October 2017 at 06:49

Thanks,
this really saved a lot of lost time.
I could not find why my importers on my new webhosting where failing with ajax errors
=> finding this issue and switching between php 5.6 and 7.1 exposed this problem for me

Many thanks for this patch!

Comment #15

ccjjmartin CreditAttribution: ccjjmartin at Four Kitchens commented 7 November 2017 at 02:38

Any reason not to do a version bump to the module for this? With the latest release of the feeds module a lot of attention is going to be given to making sure existing feeds are working: https://www.drupal.org/project/feeds