PHP Warning when using link field tokens in a view

The bug is actually in the views module according to the patch.

I think we no longer needs tests, yeaah!

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -928,7 +928,7 @@ protected function addSelfTokens(&$tokens, $item) {
-          if (!empty($property)) {
+          if (!empty($property) && is_scalar($property->getValue())) {

It would be great to have some quick comment, why we need this check here.

This for now solves a problem.

Why is $property->getValue() returning an object and if said object implements __toString() is it not okay?

Edited the content view and played around with tokens for reproducing the issue.
Did the same with the patch applied and the error disappears.

Last patch resolves concerns at #26, so I think we can set it back to RTBC.

Added beta evaluation template.

Is that a valid return value for the link token though?

Just wanted to confirm that #27 does apply and fix the problem, as of RC1. Not sure about catch's question in #29 though but hoping to see this move forward.

We know nothing about the data

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -928,11 +928,17 @@ protected function addSelfTokens(&$tokens, $item) {
+          if (!empty($property) && is_scalar($property->getValue())) {
             $tokens['{{ ' . $this->options['id'] . '__' . $id . ' }}'] = Xss::filterAdmin($property->getValue());
           }
+          elseif (is_object($property->getValue()) && method_exists($property->getValue(), '__toString')) {
+            $tokens['{{ ' . $this->options['id'] . '__' . $id . ' }}'] = Xss::filterAdmin((string) $property->getValue());

Talked with fago today. We should check whether these things are primitive items ... in which case we know how to render them.

Back to needs work

I hit this issue and tried out the patch in comment 37 and it fixed my issue.

thanks,
-mike

Thank you @lendude!!

here are a couple of nitpicks / one small remark on the test.

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -932,8 +933,10 @@ protected function addSelfTokens(&$tokens, $item) {
+          if (!empty($property) && $property instanceof TypedDataInterface) {
+            $tokens['{{ ' . $this->options['id'] . '__' . $id . ' }}'] = Xss::filterAdmin($property->getString());
           }

I like this solution now!

1. +++ b/core/modules/link/src/Tests/Views/LinkViewsTokensTest.php
   @@ -0,0 +1,99 @@
   +  protected $field_name = 'field_link';
   

   Let's just use camelcase ...

2. +++ b/core/modules/link/src/Tests/Views/LinkViewsTokensTest.php
   @@ -0,0 +1,99 @@
   +  protected function setUp() {
   

   netpick: let's use {@inheritdoc}

3. +++ b/core/modules/link/src/Tests/Views/LinkViewsTokensTest.php
   @@ -0,0 +1,99 @@
   +  function testLinkViewsTokens() {
   

   Nitpicks: Let's use public here.

4. +++ b/core/modules/link/src/Tests/Views/LinkViewsTokensTest.php
   @@ -0,0 +1,99 @@
   +      $values[$this->field_name][] = ['uri' => $uri, 'title' => $title];
   +      $this->drupalCreateNode($values);
   ...
   +      // Options is an array and should return empty after token replace.
   +      $this->assertRaw("Raw options: .");
   

   Let's fill out options to ensure that also maps are filled out properly. Those fields also have a getString() implementation.

Looks ready to me. Just one question.

+++ b/core/modules/views/src/Plugin/views/field/Field.php
@@ -932,8 +933,10 @@ protected function addSelfTokens(&$tokens, $item) {
-            $tokens['{{ ' . $this->options['id'] . '__' . $id . ' }}'] = Xss::filterAdmin($property->getValue());
...
+            $tokens['{{ ' . $this->options['id'] . '__' . $id . ' }}'] = Xss::filterAdmin($property->getString());

Do we need an update function to fix this for all the existing views using this token?

Do we need an update function to fix this for all the existing views using this token?

I don't believe so. The token doesn't change, just the value that replaces it.

I don't believe so. The token doesn't change, just the value that replaces it.

Yeah, right. Let's try to not overthing update paths.

Ok then.

+++ b/core/modules/link/src/Tests/Views/LinkViewsTokensTest.php
@@ -0,0 +1,102 @@
+      // Raw options: {{ field_link__options }}<br />
+      // Options is an array and should return empty after token replace.
+      $this->assertRaw("Raw options: .");

What is the point of having a token that can't ever be displayed? Do we need to handle this better?

IMHO this is out of scope of this issue. This is just about fixing the field tokens itself, while your request is about fixing the general token functionality in views, IMHO.
Here is a follow up: #2657024: Hide non existing views tokens

@dawehner thanks for creating #2657024: Hide non existing views tokens - I think if a token can't be made into a string then it can't be a token right... seems very wrong.

Committed ba13b1b and pushed to 8.0.x and 8.1.x. Thanks!