Problem/Motivation

#2560643: Fatal PHPUnit tests are not always reported as failure fixed a problem when a phpunit test crashed
Sadly we did not managed to get a test running on all machines

Proposed resolution

Investigate how to add proper test coverage for it.

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

chx’s picture

Status: Active » Needs review
Issue tags: -Needs tests, -D8 Accelerate
FileSize
4.46 KB

Status: Needs review » Needs work

The last submitted patch, 3: 2566963.patch, failed testing.

chx’s picture

It's not putenv.

chx’s picture

Status: Needs work » Needs review
FileSize
4.33 KB
4.33 KB

The last submitted patch, 6: 2566963_6a.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: 2566963_6b.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
FileSize
2.75 KB
2.75 KB

The last submitted patch, 9: 2566963b.patch, failed testing.

The last submitted patch, 9: 2566963b.patch, failed testing.

chx’s picture

Finally managed to reproduce this in a drupalci container. processChildResult throws a PHPUnit_Framework_Exception because stderr is segmentation fault. Normally, processes dying of segmentation fault do not produce such things and the shell does. Something about shell settings / ulimit / whatnot.

chx’s picture

This is a drupalci bug because drupalci PHP is a shell script and not a binary PHP. https://www.drupal.org/node/2567241#comment-10320861

The last submitted patch, 3: 2566963.patch, failed testing.

The last submitted patch, 6: 2566963_6a.patch, failed testing.

The last submitted patch, 6: 2566963_6b.patch, failed testing.

chx’s picture

As I mentioned in #2560643-21: Fatal PHPUnit tests are not always reported as failure we can explicitly terminate the process. I was wary of this because I am unsure how well this works on Windows but the solution is self solving: if and when we get a testbot on Windows and this test produces a failure we will have the environment we will be able to investigate. Until then noone runs the whole test suite on Windows. Theoretically this works, anyways.

chx’s picture

FileSize
2.8 KB

Doh, I forgot to put back one of the test leakage stopping annotations.

chx’s picture

FileSize
3.38 KB

Including files is not the best from a test. Removed the file.inc include.

The last submitted patch, 17: 2566963_17.patch, failed testing.

The last submitted patch, 18: 2566963_18.patch, failed testing.

The last submitted patch, 17: 2566963_17.patch, failed testing.

The last submitted patch, 18: 2566963_18.patch, failed testing.

chx’s picture

FileSize
3.26 KB

/shrugs

The last submitted patch, 19: 2566963_19.patch, failed testing.

The last submitted patch, 19: 2566963_19.patch, failed testing.

chx’s picture

FileSize
3.27 KB

GRrrrgrrrgrrr!

neclimdul’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

The last submitted patch, 24: 2566963_21.patch, failed testing.

The last submitted patch, 24: 2566963_21.patch, failed testing.

Fabianx’s picture

RTBC + 1 - Looks great!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This works for me. Committed d24a890 and pushed to 8.0.x. Thanks!

  • alexpott committed d24a890 on 8.0.x
    Issue #2566963 by chx: Follow up of 2560643 Add test coverage
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.