Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
#2560643: Fatal PHPUnit tests are not always reported as failure fixed a problem when a phpunit test crashed
Sadly we did not managed to get a test running on all machines
Proposed resolution
Investigate how to add proper test coverage for it.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#27 | 2566963_27.patch | 3.27 KB | chx |
Comments
Comment #2
dawehner.
Comment #3
chx CreditAttribution: chx commentedComment #5
chx CreditAttribution: chx commentedIt's not putenv.
Comment #6
chx CreditAttribution: chx commentedComment #9
chx CreditAttribution: chx commentedComment #12
chx CreditAttribution: chx commentedFinally managed to reproduce this in a drupalci container.
processChildResult
throws aPHPUnit_Framework_Exception
becausestderr
issegmentation fault
. Normally, processes dying of segmentation fault do not produce such things and the shell does. Something about shell settings / ulimit / whatnot.Comment #13
chx CreditAttribution: chx commentedThis is a drupalci bug because drupalci PHP is a shell script and not a binary PHP. https://www.drupal.org/node/2567241#comment-10320861
Comment #17
chx CreditAttribution: chx commentedAs I mentioned in #2560643-21: Fatal PHPUnit tests are not always reported as failure we can explicitly terminate the process. I was wary of this because I am unsure how well this works on Windows but the solution is self solving: if and when we get a testbot on Windows and this test produces a failure we will have the environment we will be able to investigate. Until then noone runs the whole test suite on Windows. Theoretically this works, anyways.
Comment #18
chx CreditAttribution: chx commentedDoh, I forgot to put back one of the test leakage stopping annotations.
Comment #19
chx CreditAttribution: chx commentedIncluding files is not the best from a test. Removed the file.inc include.
Comment #24
chx CreditAttribution: chx commented/shrugs
Comment #27
chx CreditAttribution: chx commentedGRrrrgrrrgrrr!
Comment #28
neclimdulLooks good.
Comment #31
Fabianx CreditAttribution: Fabianx as a volunteer commentedRTBC + 1 - Looks great!
Comment #32
alexpottThis works for me. Committed d24a890 and pushed to 8.0.x. Thanks!