Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Working on SafeMarkup and escaping issues are running tests from the command line is painful because assertion messages have html entities escaped. Let's offer a --non-html
flag so that we can toggle this.
Before
Pass Other ConfigInstallTest 229 Drupal\config\Tests\ConfigInstallTe
Value 'en' is equal to value 'en'.
Pass Other ConfigInstallTest 233 Drupal\config\Tests\ConfigInstallTe
Value 'fr' is equal to value 'fr'.
Pass Other ConfigInstallTest 237 Drupal\config\Tests\ConfigInstallTe
Value 'fr' is equal to value 'fr'.
After
Pass Other ConfigInstallTest 229 Drupal\config\Tests\ConfigInstallTe
Value 'en' is equal to value 'en'.
Pass Other ConfigInstallTest 233 Drupal\config\Tests\ConfigInstallTe
Value 'fr' is equal to value 'fr'.
Pass Other ConfigInstallTest 237 Drupal\config\Tests\ConfigInstallTe
Value 'fr' is equal to value 'fr'.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2566319.2.patch | 1.83 KB | alexpott |
Comments
Comment #2
alexpottComment #3
dawehner<3 <3 <3
Comment #4
stefan.r CreditAttribution: stefan.r commentedNice!
Comment #5
alexpottComment #6
alexpottComment #9
alexpottrandom pifr 0 byte fail.
Comment #10
effulgentsia CreditAttribution: effulgentsia at Acquia commentedLooks quite sensible to me. Pushed to 8.0.x.
Comment #12
effulgentsia CreditAttribution: effulgentsia at Acquia commentedHm, we now have 'xml', 'non-html', and 'browser' as available args, but not all combinations of those are sensible. Not sure if we want a follow-up to either normalize those to a different set of args, or warn when a non-sensible combination is chosen.
Comment #13
Wim LeersOMG YES!
alexpott++
Comment #14
alexpott@effulgentsia --all and --class don't make sense together either - I think it is okay to leave this up to the caller.
Comment #15
alexpott@effulgentsia also --non-html does not affect the html generated for --browser so I think we're okay.