With the Drupal 7 migrations being added to core, in some cases we've found they were identical to the Drupal 6 migrations and consolidated into a single migration for both versions. Naturally, we've removed the "Drupal 6" from the labels of the consolidated migrations. This means when running migrations through the upgrade UI (#2281691: User interface for migration-based upgrades), the feedback shows a mix of label styles - "Menu UI configuration" may be followed by "Drupal 6 custom blocks". We should remove Drupal X from all labels for consistent messaging.

In addition, certain migrations are lacking labels entirely, we need to add them.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan created an issue. See original summary.

phenaproxima’s picture

BIG +1 for this.

mikeryan’s picture

Status: Active » Needs review
FileSize
49.44 KB

Lots of files touched, but real simple. Except that MigrateNodeBuilderTest broke, because it was accidentally testing labels derived from migration_templates/d6_node.yml instead of the in-memory template it was supposed to test - that's fixed here.

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

This has passed DrupalCI, so preemptively RTBC.

mikeryan’s picture

Title: Generify migration labels » Fix migration labels
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Broadening the scope slightly - discovered a few migrations (e.g., d7_field_instance) don't even have labels.

mikeryan’s picture

Status: Needs work » Needs review
FileSize
50.16 KB
1.09 KB

Adding missing labels, and also taking out migration removed by #2410875: Migration for Drupal 7 Taxonomy vocabularies and terms.

quietone’s picture

Ran a migration and saw '6' go by. I found it in the logs, then played with old friends grep and awk and we couldn't find any other labels that need changing.

Status: Needs review » Needs work

The last submitted patch, 7: fix_migration_labels-2565791-7.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
subhojit777’s picture

Status: Needs review » Reviewed & tested by the community

+1 RTBC

phenaproxima’s picture

+++ b/core/modules/node/src/Tests/Migrate/d6/MigrateNodeBuilderTest.php
@@ -7,6 +7,7 @@
 use Drupal\migrate\Entity\Migration;

This might be unnecessary since we're no longer calling Migration::load(), but it's not worth delaying this patch over. +1 for RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

This needs a small re-roll after the taxonomy patch went in!!

subhojit777’s picture

Assigned: Unassigned » subhojit777
phenaproxima’s picture

@subhojit777: While you're at it, will you fix #12? :)

mikeryan’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
50.16 KB

Removed change to file deleted in the taxonomy patch.

subhojit777’s picture

Assigned: subhojit777 » Unassigned

@mikeryan: While you're at it, will you fix #12? :)

mikeryan’s picture

@mikeryan: While you're at it, will you fix #12?

No, I won't;). Migration is still referenced:

$this->assertTrue($migration instanceof Migration);
subhojit777’s picture

phenaproxima’s picture

Sorry @subhojit777 -- #19 is incorrect. It removes the fixes to MigrateNodeBuilderTest, so I'm thinking it won't pass testbot; #16 is correct.

Status: Needs review » Needs work

The last submitted patch, 19: fix_migration_labels-2565791-18.patch, failed testing.

phenaproxima’s picture

Status: Needs work » Reviewed & tested by the community

#16 has passed DrupalCI, so I'd say that one is RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed #16 to 8.0.x. Thanks!

  • webchick committed dc644d1 on 8.0.x
    Issue #2565791 by mikeryan, subhojit777, quietone, phenaproxima: Fix...

Status: Fixed » Needs work

The last submitted patch, 19: fix_migration_labels-2565791-18.patch, failed testing.

subhojit777’s picture

Status: Needs work » Fixed

Wrong patch got failed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.