With the Drupal 7 migrations being added to core, in some cases we've found they were identical to the Drupal 6 migrations and consolidated into a single migration for both versions. Naturally, we've removed the "Drupal 6" from the labels of the consolidated migrations. This means when running migrations through the upgrade UI (#2281691: User interface for migration-based upgrades), the feedback shows a mix of label styles - "Menu UI configuration" may be followed by "Drupal 6 custom blocks". We should remove Drupal X from all labels for consistent messaging.
In addition, certain migrations are lacking labels entirely, we need to add them.
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-2565791-14-18.txt | 1.86 KB | subhojit777 |
#19 | fix_migration_labels-2565791-18.patch | 48.3 KB | subhojit777 |
#16 | fix_migration_labels-2565791-14.patch | 50.16 KB | mikeryan |
#7 | interdiff-fix_migration_labels-6-7.txt | 326 bytes | quietone |
#7 | fix_migration_labels-2565791-7.patch | 50.62 KB | quietone |
Comments
Comment #2
phenaproximaBIG +1 for this.
Comment #3
mikeryanLots of files touched, but real simple. Except that MigrateNodeBuilderTest broke, because it was accidentally testing labels derived from migration_templates/d6_node.yml instead of the in-memory template it was supposed to test - that's fixed here.
Comment #4
phenaproximaThis has passed DrupalCI, so preemptively RTBC.
Comment #5
mikeryanBroadening the scope slightly - discovered a few migrations (e.g., d7_field_instance) don't even have labels.
Comment #6
mikeryanAdding missing labels, and also taking out migration removed by #2410875: Migration for Drupal 7 Taxonomy vocabularies and terms.
Comment #7
quietone CreditAttribution: quietone commentedRan a migration and saw '6' go by. I found it in the logs, then played with old friends grep and awk and we couldn't find any other labels that need changing.
Comment #10
quietone CreditAttribution: quietone commentedComment #11
subhojit777+1 RTBC
Comment #12
phenaproximaThis might be unnecessary since we're no longer calling Migration::load(), but it's not worth delaying this patch over. +1 for RTBC.
Comment #13
webchickThis needs a small re-roll after the taxonomy patch went in!!
Comment #14
subhojit777Comment #15
phenaproxima@subhojit777: While you're at it, will you fix #12? :)
Comment #16
mikeryanRemoved change to file deleted in the taxonomy patch.
Comment #17
subhojit777Comment #18
mikeryanNo, I won't;). Migration is still referenced:
Comment #19
subhojit777Comment #20
phenaproximaSorry @subhojit777 -- #19 is incorrect. It removes the fixes to MigrateNodeBuilderTest, so I'm thinking it won't pass testbot; #16 is correct.
Comment #22
phenaproxima#16 has passed DrupalCI, so I'd say that one is RTBC.
Comment #23
webchickCommitted and pushed #16 to 8.0.x. Thanks!
Comment #26
subhojit777Wrong patch got failed.