Problem/Motivation

#2538950: Replace SafeMarkup::format() in template_preprocess_html with placeholders in the template introduced:

<css-placeholder token="{{ placeholder_token|raw }}" />

but it could've been:

<css-placeholder token="{{ placeholder_token|raw }}">

This is simpler, and doesn't set off the spidey senses in text editors/IDEs:

<tag /> is XHTML thinking, <tag> is HTML5 thinking.

Proposed resolution

Change it.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2565033-2.patch3.01 KBWim Leers
Screen Shot 2015-09-08 at 16.55.09.png16.44 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2565033-2.patch3.01 KB
Fabianx’s picture

Fabianx CreditAttribution: Fabianx for Acquia commented
Issue summary: View changes
neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
Status: Needs review » Reviewed & tested by the community

The new one sets off my internal XML parser but that seems much less important. Hopefully fewer and fewer people will have the years of torture involved in creating one of those. +1

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Updated the CR accordingly: https://www.drupal.org/node/2565021.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Let's do this quick whilst the change is still fresh... Committed 36f6a9b and pushed to 8.0.x. Thanks!

  • alexpott committed 36f6a9b on 8.0.x 
    Issue #2565033 by Wim Leers: Follow-up for #2538950: simplify syntax

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.