Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Not sure if anyone else has noted this problem, but when using Entity Embed together with Adminimal Theme, the autocomplete results are cut off by the base of the modal popup. I've attached an image demonstrating what happens:
Has anyone spotted this issue with any other admin theme?
I've attached a patch that remedies this with some quick and dirty CSS, but in the long run it might be a better idea to send some form of command to the modal popup to force it to adjust its height when autocomplete results are returned. Given that the behaviour of autocomplete widgets is locked down pretty tight by Form API, I'm not immediately sure how we'd accomplish this.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | backport-autocomplete-fixes-2562147-3.patch | 121.79 KB | Devin Carlson |
| entity_embed_autocomplete_space.patch | 1.14 KB | geoffreyr | |
| entity-embed-dialog.jpg | 33.96 KB | geoffreyr | |
Comments
Comment #2
Devin Carlson CreditAttribution: Devin Carlson commentedThis has been fixed in D8 with #2508830: Various UI problem with autocomplete select control and #2535122: Autocomplete suggestions in modal clipped due to overflow: hidden.
These fixes should be backported to Entity Embed 1.x. The same fixes are being added to the stand-alone Dialog module in #2562179: Backport autocomplete fixes.
Comment #3
Devin Carlson CreditAttribution: Devin Carlson commentedA patch which backports both fixes as well as the more recent enhancements made to the Dialog module which were required.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedTested #3 and committed to Entity Embed 7.x-1.x.
If an individual theme is still experiencing issues then it may require minor CSS tweaks.