Problem/Motivation

The d7_menu_links migration differs slightly from its D6 counterpart in a few ways, one of which is that it does not provide a default description when a link has no title attribute. This, as it turns out, can cause exceptions and/or fatals during migration.

Proposed Resolution

Add a default value to the d7_menu_links migration.

Remaining Tasks

All of it.

API/UI Changes

None.

CommentFileSizeAuthor
#3 2562075-3.patch2.46 KBphenaproxima
#3 2562075-3-FAIL.patch1.99 KBphenaproxima
#2 2562075-2.patch481 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2562075-2.patch481 bytes

Initial patch.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: -Needs tests
FileSize
2562075-3-FAIL.patch1.99 KB
2562075-3.patch2.46 KB

Tests? Yay!

The last submitted patch, 3: 2562075-3-FAIL.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2562075-3.patch, failed testing.

Status: Needs work » Needs review

phenaproxima queued 3: 2562075-3.patch for re-testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs review » Reviewed & tested by the community

Ayup.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 3e3a207 on 8.0.x 
    Issue #2562075 by phenaproxima: D7 menu link migration must provide a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.