In the Views UI, if you are looking at a Page display, the actions dropdown in the upper right has a link to "Display page".

This link is broken. For instance if my page path is "number-test", it is taking me instead to the page (my site URL)/base%3Anumber-test

If it makes any difference, my test site is multilingual with 2 languages defined, but I'm currently looking at English.

CommentFileSizeAuthor
#8 interdiff-2561943-5-7.txt1.01 KBgeertvd
#7 views_ui_view_page-2561943-7-complete.patch2 KBgeertvd
#7 views_ui_view_page-2561943-7-test.patch906 bytesgeertvd
#5 views_ui_view_page-2561943-5-complete.patch2.08 KBgeertvd
#5 views_ui_view_page-2561943-5-test.patch990 bytesgeertvd
#3 views_ui_view_page-2561943-2.patch1.12 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
Status: Active » Needs review
Issue tags: +Needs tests

This was introduced in #2474471: Views page displays do not accept an integer as path.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at XIO commented
FileSize
views_ui_view_page-2561943-2.patch1.12 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

That was quick!

This patch fixes the problem for me. Still needs an automated web regression test, so it won't break again, so setting to Needs Work.

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
Status: Needs work » Needs review
FileSize
views_ui_view_page-2561943-5-test.patch990 bytes
views_ui_view_page-2561943-5-complete.patch2.08 KB

Added a test for this

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

That test looks overly specific to me, with all the IDs and paths and stuff in there.... Can't we just test that if we click the link on a view that's been saved, it goes to the right page? The way this test is written, it seems like if anything changes in the theme being used for the test, the test will fail.

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
Status: Needs work » Needs review
FileSize
views_ui_view_page-2561943-7-test.patch906 bytes
views_ui_view_page-2561943-7-complete.patch2 KB

How about this then?

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
FileSize
interdiff-2561943-5-7.txt1.01 KB

interdiff

The last submitted patch, 5: views_ui_view_page-2561943-5-test.patch, failed testing.

The last submitted patch, 5: views_ui_view_page-2561943-5-complete.patch, failed testing.

The last submitted patch, 7: views_ui_view_page-2561943-7-test.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

That looks great to me! The test-only patch failed with the reported bug ("base%03" in the URL), and it passes with the code patch that I had manually tested to fix the problem.

Thanks!

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Issue tags: -Needs tests

+1 LGTM

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed a8a685a and pushed to 8.0.x. Thanks!

  • alexpott committed 2acbaf2 on 8.0.x 
    Issue #2561943 by geertvd, pjonckiere, jhodgdon: Views UI - View Page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.