Looks like the description for 'administer nodes' got applied to 'administer content types'.

Expected:

The Administer content permission has the description "Promote, change ownership, edit revisions, and perform other tasks across all content types."

Actual

The Administer content types permission has the description "Promote, change ownership, edit revisions, and perform other tasks across all content types."

CommentFileSizeAuthor
#12 after2561325-8patch.png11.86 KBphantomvish
#12 before2561325-8patch.png10.69 KBphantomvish
#8 administer-nodes-description-2561325-8.patch844 byteskevin.dutra
#2 administer-nodes-description-2561325-2.patch733 byteskevin.dutra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kevin.dutra created an issue. See original summary.

kevin.dutra’s picture

kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commented
Status: Active » Needs review
FileSize
administer-nodes-description-2561325-2.patch733 bytes
sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste at OSSeed Technologies commented

I think the description is at right place as permission is related to "Administer content types". Also instead of removing it entirely I think we need to add something similar description for "Administer content".

kevin.dutra’s picture

kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commented

I disagree. Promotion, ownership (author), revisions, etc. are all operations that happen for nodes (content), not content types. Administer content types lets you adjust some of the settings/defaults for some of these things, but the way the description is currently worded, it's talking about performing the actual operations on nodes, which is what Administer content does.

But I do agree that having descriptions on both would help to differentiate.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
CreditAttribution: sushantpaste at OSSeed Technologies commented

@kevin.dutra : May be you can add patch for both fields , that will help us to review issue ?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented 
+++ b/core/modules/node/node.permissions.yml
@@ -4,10 +4,10 @@ bypass node access:
 administer content types:
   title: 'Administer content types'
-  description: 'Promote, change ownership, edit revisions, and perform other tasks across all content types.'
   restrict access: true

Should we have a description instead for 'administer content types'?

ifrik’s picture

ifrik
she/her
CreditAttribution: ifrik commented
Issue tags: +Barcelona2015
kevin.dutra’s picture

kevin.dutra CreditAttribution: kevin.dutra at Workday, Inc. commented
FileSize
administer-nodes-description-2561325-8.patch844 bytes

Alrighty, this one includes a first attempt at a new description for 'administer content types'.

Status: Needs review » Needs work

The last submitted patch, 8: administer-nodes-description-2561325-8.patch, failed testing.

Status: Needs work » Needs review

kevin.dutra queued 8: administer-nodes-description-2561325-8.patch for re-testing.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Issue tags: +Novice
phantomvish’s picture

phantomvish CreditAttribution: phantomvish commented
Issue summary: View changes
FileSize
before2561325-8patch.png10.69 KB
after2561325-8patch.png11.86 KB

The patch works, the permission descriptions are updated as expected.
before
after

phantomvish’s picture

phantomvish CreditAttribution: phantomvish commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 247c9a4 and pushed to 8.0.x. Thanks!

  • alexpott committed 247c9a4 on 8.0.x 
    Issue #2561325 by kevin.dutra, phantomvish: Wrong description for '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.