Problem/Motivation

The forum.css file within Bartik is missing a file comment. This goes against Core CSS coding standards.

Proposed resolution

Add a file comment in the correct format, see here for details... https://www.drupal.org/node/1887862/#file-comments

Remaining tasks

Create a patch
Review the format and content of the file comment produced.

User interface changes

none

API changes

none

Data model changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is formatting of CSS files.
Issue priority Not critical because it is coding standards work and the functioning code works fine.
Prioritized changes The main goal of this issue is providing good examples of code in Core.
Disruption Non disruptive, it is adding a file comment.
CommentFileSizeAuthor
#5 forum_css_missing_file_comment-2560245-5.patch353 bytesrudraram
#2 forum_css_missing_file_comment-2560245-2.patch352 bytesrudraram
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria created an issue. See original summary.

rudraram’s picture

rudraram CreditAttribution: rudraram at Axelerant commented
Status: Active » Needs review
FileSize
forum_css_missing_file_comment-2560245-2.patch352 bytes

Added the comment.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs review » Needs work

There are few other css file which need this file block. For example - form.css in seven and few others.
So I think, instead of single file, we should do this for all in one go, otherwise we this will have many small patches

Thoughts ?

If yes, then IS needs update.

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented

@joshi.rohit100
There are open issues for all of the CSS files and their components which you can find listed here #1342054: [META] Clean up templates and CSS.
The forum code was worked on as part of this Core issue #2408513: Refactor forum module CSS files inline with our CSS standards but they missed the Bartik file comment so I raised that specific issue here, thanks :)

One small nit with the patch, can it say 'Visual styles for forums in Bartik'. Forums come from the Forum module and are not owned by Bartik, thanks :)

+++ b/core/themes/bartik/css/components/forum.css
@@ -1,3 +1,8 @@
+ * Visual styles for Bartik's forums.
rudraram’s picture

rudraram CreditAttribution: rudraram at Axelerant commented
Status: Needs work » Needs review
FileSize
forum_css_missing_file_comment-2560245-5.patch353 bytes

@emma.maria Just updated the patch as per your suggestion.

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Needs review » Reviewed & tested by the community

The patch in #5 looks great. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: forum_css_missing_file_comment-2560245-5.patch, failed testing.

Status: Needs work » Needs review

joshi.rohit100 queued 5: forum_css_missing_file_comment-2560245-5.patch for re-testing.

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Status: Needs review » Reviewed & tested by the community

This patch still applies cleanly. I'm going to set it back to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed e9a960b and pushed to 8.0.x. Thanks!

  • alexpott committed e9a960b on 8.0.x 
    Issue #2560245 by rudraram, emma.maria: forum.css is missing a file...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.