Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Some documentation around SafeMarkup
was left in the test comments.
+++ b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
@@ -364,16 +364,19 @@ public function testGenerateWithHtml() {
+ // Test that safe HTML is output inside the anchor tag unescaped. The
+ // SafeMarkup::set() call is an intentional unit test for the interaction
+ // between SafeMarkup and the LinkGenerator.
Proposed resolution
Rewrite the addition added by #2501705: Remove SafeMarkup::set() in LinkGenerator and document SafeMarkup::set() in LinkGeneratorTest because there is no longer SafeMarkup
there and instead SafeStringInterface
.
Remaining tasks
User interface changes
API changes
Data model changes
Follow-up to #2501705: Remove SafeMarkup::set() in LinkGenerator and document SafeMarkup::set() in LinkGeneratorTest
Beta phase evaluation
Issue category | Task because it's cleanup |
---|---|
Issue priority | Normal because it's a child of critical but doc cleanup |
Unfrozen changes | Unfrozen because it only changes documentation in tests. |
Comment | File | Size | Author |
---|---|---|---|
#2 | linkgeneratortest_and-2557411-2.patch | 911 bytes | joelpittet |
Comments
Comment #2
joelpittetComment #3
joelpittetComment #4
joelpittetComment #5
jhodgdonWell that looks pretty harmless. :)
Comment #6
joelpittetThe patch byte size only makes it look alarming.
Comment #7
jhodgdonHah!
Comment #8
webchickLOL :)
Committed and pushed to 8.0.x. Thanks!