Problem/Motivation

Some documentation around SafeMarkup was left in the test comments.

+++ b/core/tests/Drupal/Tests/Core/Utility/LinkGeneratorTest.php
@@ -364,16 +364,19 @@ public function testGenerateWithHtml() {
+    // Test that safe HTML is output inside the anchor tag unescaped. The
+    // SafeMarkup::set() call is an intentional unit test for the interaction
+    // between SafeMarkup and the LinkGenerator.

Proposed resolution

Rewrite the addition added by #2501705: Remove SafeMarkup::set() in LinkGenerator and document SafeMarkup::set() in LinkGeneratorTest because there is no longer SafeMarkup there and instead SafeStringInterface.

Remaining tasks

User interface changes

API changes

Data model changes

Follow-up to #2501705: Remove SafeMarkup::set() in LinkGenerator and document SafeMarkup::set() in LinkGeneratorTest

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it's cleanup
Issue priority Normal because it's a child of critical but doc cleanup
Unfrozen changes Unfrozen because it only changes documentation in tests.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

Status: Active » Needs review
FileSize
911 bytes
joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

Priority: Major » Normal
Issue tags: +Quick fix
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Well that looks pretty harmless. :)

joelpittet’s picture

The patch byte size only makes it look alarming.

jhodgdon’s picture

Hah!

webchick’s picture

Title: LinkGeneratorTest and document SafeMarkup::set() in » Remove obsolete reference to SafeMarkup::set() in LinkGeneratorTest documentation
Status: Reviewed & tested by the community » Fixed

The patch byte size only makes it look alarming.

LOL :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 935a500 on 8.0.x
    Issue #2557411 by joelpittet: Remove obsolete reference to SafeMarkup::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.