Problem/Motivation

#2506195: Remove SafeMarkup::set() from Xss::filter() removed the SafeMarkup::set() from Xss::filter(), but didn't fix the comment above it.

Proposed resolution

Fix the comment.

Remaining tasks

Wait until I submit this, so I can create a patch with the right issue number.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2556895-02.patch898 bytesmpdonadio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mpdonadio created an issue. See original summary.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Active » Needs review
FileSize
2556895-02.patch898 bytes

I would call this a contender for trivial patch of the week, but having comments match code is important.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Category: Task » Bug report
Status: Needs review » Reviewed & tested by the community
Issue tags: +Documentation, +SafeMarkup

As I recall inaccurate docs are a bug but could be wrong. Thanks, RTBC!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 08beef0 and pushed to 8.0.x. Thanks!

  • alexpott committed 08beef0 on 8.0.x 
    Issue #2556895 by mpdonadio: Fix comment in Xss::filter()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.