Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The indentation on the docblock in \Drupal\Core\Field\Plugin\Field\FieldFormatter\TimestampAgoFormatter for the $request property is incorrect.
Proposed resolution
Fix it.
Remaining tasks
Do it.
User interface changes
None.
API changes
None.
Data model changes
None.
Beta phase evaluation
Issue category | Task because it's a simple doc fix. |
---|---|
Issue priority | Minor because the indentation is just wrong |
Unfrozen changes | Unfrozen because it only changes documentation/ |
Disruption | None |
Comment | File | Size | Author |
---|---|---|---|
#12 | timestampago-2555911-12.patch | 756 bytes | sdstyles |
Comments
Comment #2
Kuldip Gohil CreditAttribution: Kuldip Gohil as a volunteer and commentedIt looks fine to me.
Comment #3
amitshah2007 CreditAttribution: amitshah2007 commentedpatch file is attached.
Comment #4
amitshah2007 CreditAttribution: amitshah2007 commentedComment #5
sushylsmall nitpick, this will be fixed at the time of committing.It would be good to reroll before getting committed.
Comment #6
meramo CreditAttribution: meramo as a volunteer and at Bright Solutions GmbH commentedRerolled. Applies without issues.
Comment #7
ravi.kiran CreditAttribution: ravi.kiran as a volunteer commentedpatch rerolled.
Comment #8
ankur7213 CreditAttribution: ankur7213 commentedThe patch at #7 is not valid as the changes required are not in the scope of this issue.
Patch at #3 should be rerolled with the changes mentioned at #5.
Comment #9
amitshah2007 CreditAttribution: amitshah2007 commentednew patch file generated removing space line.
Comment #10
amitshah2007 CreditAttribution: amitshah2007 commentedComment #11
mpdonadioThanks for the effort, but we are still not there.
#3 has the correct change to TimestampAgoFormatter(), but an out of scope change to EntityHandlerBase().
#7 and #9 change EntityHandlerBase(), and don't touch TimestampAgoFormatter().
All we need to do is fix the indentation in TimestampAgoFormatter() at
Also, when uploading new patches, you typically include an interdiff to show reviews what has changed between patch versions.
Comment #12
sdstyles CreditAttribution: sdstyles at FFW commentedFixed indentation in TimestampAgoFormatter.
Comment #13
mpdonadio#12 looks good to me. Thanks.
Comment #14
alexpottCommitted 45aca27 and pushed to 8.0.x. Thanks!