Problem/Motivation

\Drupal\views_ui\ViewEditForm::addMicroweights() is not necessary anymore since #2448765: Element::children sort order undefined and slower than it could be - This makes tests fail in PHP7 was comitted.

Proposed resolution

Remove it, it's useless code.

Remaining tasks

Review / commit.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because nothing is broken.
Prioritized changes The main goal of this issue is cleanup / removing unneeded code.
Disruption None.
CommentFileSizeAuthor
#2 2552797.patch1.49 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2552797.patch1.49 KB

Easy one.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Nice!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Less code to maintain. Thank you. Committed 7d08e33 and pushed to 8.0.x. Thanks!

  • alexpott committed 7d08e33 on 8.0.x 
    Issue #2552797 by amateescu: Remove \Drupal\views_ui\ViewEditForm::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.