Expand display "Comment" trim from 10 to 80 characters

Why not also add an ellipsis, …, so the views administrator knows the string was truncated?

Why not also add an ellipsis, …, so the views administrator knows the string was truncated?

+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -1130,7 +1130,7 @@ public function optionsSummary(&$categories, &$options) {
-    $display_comment = Unicode::substr($this->getOption('display_comment'), 0, 10);
+    $display_comment = Unicode::substr($this->getOption('display_comment'), 0, 80);

Good idea!
So let's use \views_ui_truncate() .., which does the ellipsis thing

I tacked a regression test onto another test or we could make another one, or rename the test I modified.

In the next patch, DisplayPluginBase may have this removed now:

use Drupal\Component\Utility\Unicode;

+++ b/core/modules/views_ui/src/Tests/ViewEditTest.php
@@ -57,6 +57,11 @@ public function testMachineNameOption() {
+    $edit = array('display_comment' => 'one two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen');
+    $this->drupalPostForm('admin/structure/views/nojs/display/test_view/attachment_1/display_comment', $edit, 'Apply');
+    $this->assertText('one two three four five six seven eight nine ten eleven twelve thirteen fourteen...');

Nice ...

I've reviewed the code, which looks good to me. And manually reviewed the patch, which seems like an improvement to me.

Before:

After:

Why are we truncating at all? The description is 'This description will only be seen within the administrative interface and can be used to document this display.'

I guess it is okay and definitely an improvement. Committed 28088f3 and pushed to 8.0.x. Thanks!

Someone can move this to the Views queue for the D7 backport.

Why are we truncating at all?

That is the question.

The comment field is set to 80 for me in D7 views 7.x-3.x.

In the file views_plugin_dispaly.inc line: 1153

$display_comment = check_plain(views_ui_truncate($this->get_option('display_comment'), 80));

Here is a view:

I believe there is no action required for 7.x-3.x

thanks,
Geoff