Why? Cause I like faster tests and tests with less dependencies allow us to only test the code we want to rather than unwanted side effects.

Beta evaluation: Allowed because only changing test code.

CommentFileSizeAuthor
#3 searchexcerpttest_and-2549921-3.patch1.61 KBborisson_
#3 interdiff.txt466 bytesborisson_
d8.search_excerpt_test.patch1.62 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community
FileSize
interdiff.txt466 bytes
searchexcerpttest_and-2549921-3.patch1.61 KB

Tests still test the same thing. I only changed array notation so I feel comfortable setting this to RTBC.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Looks reasonable to me, and the tests still pass. +1 for RTBC. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Faster tests FTW.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 8c81124 on 8.0.x 
    Issue #2549921 by borisson_, alexpott: SearchExcerptTest and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.