Problem/Motivation

ThemeLocalTask receives two parameters, a config factory and a theme handler. The only use of the config factory is to get the system default theme, but the theme handler already has a method that does this.

Proposed resolution

Remove the config factory, use ThemeHandler::getDefault() instead.

Remaining tasks

Needs review.

User interface changes

None.

API changes

Removed parameter from a constructor that is never directly called.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because it is a small cleanup
Issue priority Normal, because the impact is not that high.
Disruption No disruption
CommentFileSizeAuthor
#2 2549127-2.patch2.27 KBMattA
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MattA created an issue. See original summary.

MattA’s picture

MattA CreditAttribution: MattA commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2549127-2.patch2.27 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Less dependencies makes sense. Committed eee99e2 and pushed to 8.0.x. Thanks!

  • alexpott committed eee99e2 on 8.0.x 
    Issue #2549127 by MattA: ThemeLocalTask does not need a config factory...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.