Follow-up to #2533886: [meta] Move module-specific migration support into the particular modules supported

Just a few bits that were missed in the massive migration migration:

  • EntityDateFormat - the date_format entity is implemented in lib/Drupal/Core, so I think this should move to the system module.
  • EntityNodeType should move to the node module.
  • @phenaproxima - please remind me, the CCK field plugins like FileField, those will be going away in the aftermath of the builder patch, correct? If not, they should move to their respective modules.
  • Similar question on the CckFile and CckLink process plugins (although I'm pretty sure those won't be going away).
  • Some migrate_drupal D6 unit tests got left behind - TestComment, TestNode, TestNodeRevision, TestTerm.
CommentFileSizeAuthor
#3 move_last_stragglers_of-2546993-2.patch12.53 KBmikeryan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented

cckfield plugins should be moved into their constituent modules, but they are not going away.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Active » Needs review
FileSize
move_last_stragglers_of-2546993-2.patch12.53 KB

Here they go... Note that those unit test files actually weren't being used (I believe they're orphans from a previous approach to testing, where we needed to extend some classes in order to access protected properties), so I removed them entirely.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

So long, stragglers! Parting is such sweet sorrow.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed c737410 on 8.0.x 
    Issue #2546993 by mikeryan, phenaproxima: Move last stragglers of module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.