Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
We need it because the name does not communicate at all what is actually going on in this class.
Proposed resolution
Rename RegisterKernelListenersPass
to RegisterEventSubscribersPass
Remaining tasks
Create patch.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Beta phase evaluation
Issue category | Task because we just have to rename the class. This is just a DX improvement. |
---|---|
Issue priority | Not critical because this is not any vulnerability/performance issue |
Comment | File | Size | Author |
---|---|---|---|
#12 | rename-2546782-12.patch | 6.26 KB | Nikolay Shapovalov |
#6 | interdiff-6.txt | 705 bytes | joshi.rohit100 |
#6 | 2546782-6.patch | 2.64 KB | joshi.rohit100 |
#4 | 2546782-3.patch | 2.63 KB | joshi.rohit100 |
|
Comments
Comment #2
joshi.rohit100Comment #3
dawehnerWhile doing that I think we should document this class
Comment #4
joshi.rohit100Comment #5
dawehnerWell it doesn't really register to the container but rather to the event dispatcher
Comment #6
joshi.rohit100Comment #7
joshi.rohit100Comment #8
subhojit777#6 fixes the problem. Patch looks good. Tests all green. Good to go.
Comment #10
dawehnerComment #11
dawehnerWe need an issue summary and beta evaluation as well here.
Comment #12
Nikolay ShapovalovRerolled.
Comment #13
subhojit777Comment #14
subhojit777Comment #15
subhojit777#12 Looks good :)
Comment #16
joshi.rohit100As per #12, we are deleting and then creating new one, which is making this patch heavy. Instead, it should just rename it.
Comment #17
cilefen CreditAttribution: cilefen as a volunteer commentedRe #16,
git diff -M10%
will make a smaller patch.Comment #18
joshi.rohit100@cilefen: You got me with that -M :)
Comment #19
subhojit777@joshi.rohit100 I guess it back to needs review then.
Comment #20
cilefen CreditAttribution: cilefen as a volunteer commented@joshi.rohit100
In a good way?
Comment #21
joshi.rohit100@cilefen:
Yes. The tricky part was '-M' for this patch :)
Comment #22
dawehnerWell yeah the patch is still fine IMHO :) It is just not the right format
Comment #23
alexpottSo if anything is depending on this well they shouldn't and this is an improvement in clarity that brings understanding so I'm going to commit it under the committer discretion proviso. Committed f99f051 and pushed to 8.0.x. Thanks!