Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As amateescu and I work towards Upsert for #2336627: Deadlock on cache_config (DatabaseBackend::setMultiple()) we found we can remove ~200 LoC from Drupal core. It reduces fragility by not having to maintain the same code N times instead uses a simple trait. There's no disruption as we do not change APIs just moved conditions under one roof.
Comment | File | Size | Author |
---|---|---|---|
#1 | interdiff.txt | 1.35 KB | amateescu |
#1 | qct-1.patch | 17.45 KB | amateescu |
| |||
qct.patch | 16.65 KB | chx | |
|
Comments
Comment #1
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedMade a few small doc fixes, this looks ready to go :)
Comment #2
dawehnerNice!
Comment #3
Crell CreditAttribution: Crell at Palantir.net commented<3
Comment #4
alexpottAS this will make work on patches like #2336627: Deadlock on cache_config (DatabaseBackend::setMultiple()) much easier I think we should do. There is not a lot of change going on in the database layer so disruption is minimal. However because this is a task we need a beta evaluation before I can commit. Granting one off exceptions is not fair to other patches.
Comment #5
chx CreditAttribution: chx commentedThe issue summary, however short, already contains the beta evaluation but here it is again:
Comment #6
alexpottThanks @chx.
To me this is no-brainer. Committed cd5a8cf and pushed to 8.0.x. Thanks!
Comment #8
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedI saw this tag being used in every issue that added a trait, maybe it helps with something.