BackendCompilerPassTest::testProcess fails when sqlite not installed [#2539310]

This happens when you don't have pdo_sqlite enabled.

There was 1 failure:

1) Warning
The data provider specified for Drupal\Tests\Core\DependencyInjection\Compiler\BackendCompilerPassTest::testProcess is invalid.
could not find driver

Skip sqlite portion when sqlite is not available.

Comment	File	Size	Author
#6	2539310.6.patch	971 bytes	alexpott
#6	8.0.x: PHP 5.5 & MySQL 5.5 12,987 pass
#3	2539310.3.patch	932 bytes	alexpott
#3	8.0.x: PHP 5.5 & MySQL 5.5 12,982 pass
#2	2539310-2.interdiff.txt	836 bytes	neclimdul
#2	2539310-2.patch	1.35 KB	neclimdul
#2	8.0.x: PHP 5.5 & MySQL 5.5 12,987 pass
	BackendCompilerPassTest-sqlite-fix.patch	1.35 KB	neclimdul
	8.0.x: PHP 5.5 & MySQL 5.5 12,985 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 July 2015 at 15:18

File	Size
2539310-2.patch	1.35 KB
8.0.x: PHP 5.5 & MySQL 5.5 12,987 pass
2539310-2.interdiff.txt	836 bytes

File	Size
BackendCompilerPassTest-sqlite-fix.patch	1.35 KB
8.0.x: PHP 5.5 & MySQL 5.5 12,985 pass

File	Size
2539310.3.patch	932 bytes
8.0.x: PHP 5.5 & MySQL 5.5 12,982 pass

Comment #4

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 July 2015 at 16:32

Status:

Needs review

» Reviewed & tested by the community

Even better, no failures.

Comment #5

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 July 2015 at 19:57

Status:

Reviewed & tested by the community

» Needs work

actually... it works in php 5.6 but just ran it in 5.5 and it failed.

1) Warning
The data provider specified for Drupal\Tests\Core\DependencyInjection\Compiler\BackendCompilerPassTest::testProcess is invalid.
You cannot serialize or unserialize PDO instances

File	Size
2539310.6.patch	971 bytes
8.0.x: PHP 5.5 & MySQL 5.5 12,987 pass

Comment #7

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 July 2015 at 20:27

Status:

Needs review

» Reviewed & tested by the community

now we're good. passes in 5.5 and 5.6!

Comment #8

catch

he/him

English

CreditAttribution: catch commented 24 July 2015 at 21:26

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 8.0.x, thanks!

Comment #9

24 July 2015 at 21:26

catch committed bfa386e on 8.0.x

Issue #2539310 by neclimdul, alexpott: BackendCompilerPassTest::...

Comment #10

chx CreditAttribution: chx commented 25 July 2015 at 07:26

Odd. How can you not have pdo_sqlite when the test runner script needs --sqlite ?

Comment #11

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 25 July 2015 at 08:08

--sqlite is not required. The test bots use it, but it's not required to run tests locally, that's what this issue was about.

Comment #12

chx CreditAttribution: chx commented 25 July 2015 at 08:16

Oh. Can we open an issue and make sqlite required? :) I wanted that at least since #332303: bootstrap from sqlite but perhaps even older than that (and no, that issue is not fixed but w/e)

Comment #13

neclimdul

He/Him

CreditAttribution: neclimdul commented 27 July 2015 at 15:15

Last 3 comments have a bit of a flawed assumption, run-test.sh isn't the only way to run tests. I have CI just running ./core/vendor/bin/phpunit which doesn't require sqlite. All tests requiring sqlite politely skip. This is enough to test the patches to CI all the patches I'm working on and requires orders of magnitude less resources and time.

I would have proposed using skip like similar issues but the failure is actually in the data provider which is just always run so this is a trivial fix to avoid ugly errors.