API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...
Enter a descriptive title (above) relating to function hook_modules_installed, then describe the problem you have found:
Using 8.0.0-beta12
Please indicate in the documentation which file this hook should be implemented.
Following the convention of hook_install, I implemented hook_modules_installed in the .install file where this hook did not work.
After implementing hook_modules_installed in the .module file, it worked as expected.
Please clarify this so future developers don't make this same mistake.
Thanks.
Comment | File | Size | Author |
---|---|---|---|
#16 | hook_modules_installed-2538158-15-D7.patch | 504 bytes | joyceg |
| |||
#8 | hook_modules_installed-2538158-8.patch | 599 bytes | joyceg |
Comments
Comment #1
dreambubbler CreditAttribution: dreambubbler as a volunteer and at Acquia commentedComment #2
jhodgdonGood idea. I would have been caught by this too. Sounds like a good Novice issue -- should be pretty easy to patch this.
Note: looking at the code that invokes this, I can confirm it is being invoked with a standard moduleHandler->invokeAll() call, so yes it must be in the .module file to be invoked. And definitely we should document this.
Thanks!
Comment #3
jhodgdonProbably also need to backport to D7 after we fix it in D8.
Comment #4
joyceg CreditAttribution: joyceg commentedI am working on this issue.
Comment #5
joyceg CreditAttribution: joyceg commentedComment #6
joyceg CreditAttribution: joyceg commentedComment #7
joyceg CreditAttribution: joyceg commentedComment #8
joyceg CreditAttribution: joyceg commentedComment #9
joyceg CreditAttribution: joyceg commentedComment #10
joyceg CreditAttribution: joyceg commentedComment #11
joyceg CreditAttribution: joyceg commentedAdding the patch for Drupal 7.
Comment #12
joyceg CreditAttribution: joyceg commentedComment #16
joyceg CreditAttribution: joyceg commentedIam adding the new patch for Drupal 7.
Comment #18
roderik...and reviewed.
I thought I read that that the test bot ignored patches ending in -D7, apparently that's old information.
So - #8 for D8
#16 or D7 included too.
Comment #19
jhodgdonIn general, we work on issues one version at a time. So we would want to work on the Drupal 8 patch until Drupal 8 has been finalized, and then backport to Drupal 7. See
https://www.drupal.org/node/1319154#multiple-versions
Anyway, I agree that the patch in #8 is fine for Drupal 8, and #16 for Drupal 7.
Comment #20
alexpottDocs changes are not frozen in beta. Committed b51dc5c and pushed to 8.0.x. Thanks!
Comment #22
cilefen CreditAttribution: cilefen commentedThe hook exists in Drupal 8 so it must be patched there first.
Comment #23
cilefen CreditAttribution: cilefen commentedOops.
Comment #24
jhodgdon#16 patch is RTBC for Drupal 7.
Comment #25
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedCommitted to 7.x - thanks!