Documentation of first param of ViewsUIController::edit() is not relevant as it is about "deleted view" where we are in an edit context.

  /**
   * Returns the form to edit a view.
   *
   * @param \Drupal\views_ui\ViewUI $view
   *   The view being deleted.
   * @param string|null $display_id
   *   (optional) The display ID being edited. Defaults to NULL, which will load
   *   the first available display.
   *
   * @return array
   *   An array containing the Views edit and preview forms.
   */
  public function edit(ViewUI $view, $display_id = NULL) {
    ...
  }
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vbouchet’s picture

Version: 8.0.0-beta12 » 8.0.x-dev
Status: Active » Needs review
FileSize
672 bytes
vbouchet’s picture

Issue summary: View changes
cilefen’s picture

Title: Doc of first param of ViewsUIController::edit() not relevant » First param of ViewsUIController::edit() is documented wrong
longwave’s picture

Status: Needs review » Reviewed & tested by the community
jhodgdon’s picture

Issue tags: +Quick fix

Good catch, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed e4ac0f8 and pushed to 8.0.x. Thanks!

  • alexpott committed e4ac0f8 on 8.0.x
    Issue #2536448 by vbouchet: First param of ViewsUIController::edit() is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.