Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff.txt | 2.1 KB | chx |
#10 | 2534926_10.patch | 2.92 KB | chx |
Comments
Comment #1
chx CreditAttribution: chx commentedComment #2
Berdirform_id => form class I'd say. And "... on an entity and operation."
And possibly append: "It will then look up the corresponding form class based that information."
Comment #3
chx CreditAttribution: chx commentedComment #4
chx CreditAttribution: chx commentedComment #5
dawehnerThis is a little bit unclear as this is just true if the previous request was a POST one already.
Comment #6
chx CreditAttribution: chx commentedI copied that from existing documentation :) on FormBuiderInterface, I believe.
Comment #7
jhodgdonLooks good! A few small-ish suggestions:
So I think formBuilderInterface normally (or at least sometimes) would get the form from the ID, right?
So maybe rewrite this as:
... instead of looking up the form class by class name or form ID, it looks up the form class based on the entity type and operation.
nitpick: serial comma (add a comma after "validation").
Also I do not think page-load should have a hyphen in it.
nitpick: only one blank line here.
This is a comma splice (bad!). Replace the comma after "form handlers" with a ; and you'll be OK.
I think I would omit this line. Storage handlers are not relevant to this method.
Comment #8
chx CreditAttribution: chx commentedComment #9
jhodgdonLooks great to me except minor stuff...
nitpick: needs space after .
Is this supposed to be book_entity_type_build() or hook_entity_type_build() really?
is pageload a word? I think it would be "page load". ?
Comment #10
chx CreditAttribution: chx commented> Is this supposed to be book_entity_type_build() or hook_entity_type_build() really?
Book. Changed to system to avoid confusion.
Comment #11
jhodgdonThis all looks good to me now, thanks! Setting to RTBC... there may be some other reviews though so maybe wait a day or two to commit?
Comment #12
tim.plunkett+1 from me.
Comment #13
alexpottEntityFormBuilderInterface has received its love. Committed 9e9c0ac and pushed to 8.0.x. Thanks!