Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Problem/Motivation
Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for node migration into the node module.
Proposed resolution
For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.
Migration templates to be moved:
- d6_node
- d6_node_revision
- d6_node_setting_promote
- d6_node_setting_status
- d6_node_setting_sticky
- d6_node_settings
- d6_node_type
- d6_view_modes
Remaining tasks
Submit a patch.
User interface changes
N/A
API changes
Namespaces of affected migration plugins will change.
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#19 | interdiff-2534022-17-19.txt | 3.09 KB | phenaproxima |
#19 | 2534022-19.patch | 28.16 KB | phenaproxima |
#17 | interdiff-2534022-15-17.txt | 389 bytes | phenaproxima |
#17 | 2534022-17.patch | 26.4 KB | phenaproxima |
#15 | interdiff-2534022-13-15.txt | 744 bytes | phenaproxima |
Comments
Comment #1
phenaproximaComment #2
phenaproximaComment #3
phenaproximaBlocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.
Comment #5
phenaproximaYeah, no kidding, testbot. Still postponed.
Comment #6
phenaproximaMoved the tests into the Drupal\node\Tests\Migrate namespace, and added all view mode migration stuff.
Comment #7
phenaproximaDerp, forgot to move a unit test.
Comment #8
phenaproximaUgh...remember, kids, when you move a test, it helps to actually move the test.
Or, as this Spongebob meme summarizes: http://cdn.meme.am/instances/500x/35288674.jpg
Comment #9
phenaproximaUnblocked.
Comment #13
phenaproximaIt's kind of amazing how a single bad use statement can bring down the entire house of cards...
Comment #15
phenaproximaGo again?
Comment #17
phenaproximaMy kingdom for a green!
Comment #18
mikeryanAfter applying all the move changes, I believe the following need to be moved from migrate_drupal.source.schema.yml to the node module:
Comment #19
phenaproximaMoved.
Comment #23
phenaproximaTestbot and its weird failures.
Comment #24
mikeryanLooks good to me!
Comment #25
alexpottCommitted 6feb57b and pushed to 8.0.x. Thanks!