Instead of mocking TypedDataManager, use TypedDataManagerInterface in tests

,

This is my first patch, let me know if i made some mistake.

Check \Drupal\Tests\Core\Plugin\Context\ContextTest class as well

Thank you, @joshi.rohit100.

It seems there are other places where the TypedDataManager is mocked.

• core/tests/Drupal/Tests/Core/Plugin/Context/ContextTypedDataTest.php Line:37
• core/tests/Drupal/Tests/Core/Plugin/Context/ContextDefinitionTest.php Line:64
• core/tests/Drupal/Tests/Core/Plugin/Context/ContextDefinitionTest.php Line:130
• core/tests/Drupal/Tests/Core/Plugin/Context/ContextTest.php Line:49
• core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php Line:38
• core/tests/Drupal/Tests/Core/Entity/ContentEntityBaseUnitTest.php Line:133
• core/tests/Drupal/Tests/Core/Entity/TypedData/EntityAdapterUnitTest.php Line:139
• core/modules/views/tests/src/Unit/EntityViewsDataTest.php Line:86
• core/modules/serialization/tests/src/Unit/Normalizer/ListNormalizerTest.php Line:40

Thanks, dagmar.
I added the others and i tested them.

Looks good.

$ egrep -unr "getMockBuilder.*TypedDataManager"

./core/tests/Drupal/Tests/Core/Plugin/Context/ContextTypedDataTest.php:37:    $typed_data_manager = $this->getMockBuilder('Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Plugin/Context/ContextDefinitionTest.php:64:    $mock_data_manager = $this->getMockBuilder('\Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Plugin/Context/ContextDefinitionTest.php:129:    $mock_data_manager = $this->getMockBuilder('\Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Plugin/Context/ContextTest.php:49:    $this->typedDataManager = $this->getMockBuilder('Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Field/BaseFieldDefinitionTestBase.php:38:    $typed_data_manager = $this->getMockBuilder('\Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Entity/ContentEntityBaseUnitTest.php:133:    $this->typedDataManager = $this->getMockBuilder('\Drupal\Core\TypedData\TypedDataManagerInterface')
./core/tests/Drupal/Tests/Core/Entity/TypedData/EntityAdapterUnitTest.php:139:    $this->typedDataManager = $this->getMockBuilder('\Drupal\Core\TypedData\TypedDataManagerInterface')
./core/modules/views/tests/src/Unit/EntityViewsDataTest.php:86:    $typed_data_manager = $this->getMockBuilder('Drupal\Core\TypedData\TypedDataManagerInterface')
./core/modules/serialization/tests/src/Unit/Normalizer/ListNormalizerTest.php:40:    $typed_data_manager = $this->getMockBuilder('Drupal\Core\TypedData\TypedDataManagerInterface')

+++ b/core/modules/serialization/tests/src/Unit/Normalizer/ListNormalizerTest.php
@@ -37,9 +37,8 @@ class ListNormalizerTest extends UnitTestCase {
+    $typed_data_manager = $this->getMockBuilder('Drupal\Core\TypedData\TypedDataManagerInterface')
       ->disableOriginalConstructor()
-      ->setMethods(array('getPropertyInstance'))
       ->getMock();

This can be shorten to $typed_data_manager = $this->getMock(TypedDataManagerInterface::class);
You might need to add a use statement in a few places but ::class is preferred to strings of class names.

@alexpott sounds good, but if we do that all the tests cases will have a mix of ClassName::class and Drupal\namespace\ClassName.

What do you think about committing this issue as is and creating a new META issue to replace all the occurrences of this Drupal\namespace\ClassName to ClassName::class in tests that creates mock objects?

@dagmar I think the sting vs ::class inconsistency is ok. However using getMockBuilder()->disableOriginalConstructor()->getMock() on an interface is not. There's no constructor on an interface.

Let see if the tests pass with this.

@dagmar they are unit tests - you can run them before submitting the patch :) also just $this->getMock(TypedDataManagerInterface::class); is enough - there is no need to call $this->getMockBuilder().

For #15

According to @alexpott let's use only $this->getMock(TypedDataManagerInterface::class); call. Tested locally and all seems to be ok. Hope it works.

I review all ocurrences of TypedDataManagerInterface and look goods to me!

+++ b/core/modules/serialization/tests/src/Unit/Normalizer/ListNormalizerTest.php
@@ -37,10 +37,7 @@ class ListNormalizerTest extends UnitTestCase {
+    $typed_data_manager = $this->getMock('Drupal\Core\TypedData\TypedDataManagerInterface');
...
diff --git a/core/modules/views/tests/src/Unit/EntityViewsDataTest.php b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php

Let's change every place already touched by this patch from using the string 'Drupal\Core\TypedData\TypedDataManagerInterface' to use TypedDataManagerInterface::class. This is better because it makes any future refactor simpler.

Ok, i changed all strings on the patch.

Nice!

Committed 11d4d9f and pushed to 8.1.x and 8.2.x. Thanks!