Problem/Motivation
Those two methods are no longer needed. They either don't do anything useful or in the case of CommentForm might even override the language configuration.
Proposed resolution
Remove the two methods.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#1 | 2527406.patch | 1.74 KB | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyLet's see if something fails. Nothing should :)
Comment #2
BerdirYes, everything is happy, so let's do this.
Comment #3
xjmYay for removing dead(ish) code!
I considered whether this would need a change record, but I think not since they will just fall back to the parent implementation if someone was subclassing this, and they're protected methods.
This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed and pushed to 8.0.x. Thanks!
Comment #5
Gábor HojtsyYay less code!