Problem/Motivation

Those two methods are no longer needed. They either don't do anything useful or in the case of CommentForm might even override the language configuration.

Proposed resolution

Remove the two methods.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#1 2527406.patch1.74 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Status: Active » Needs review
Issue tags: +sprint
FileSize
1.74 KB

Let's see if something fails. Nothing should :)

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Yes, everything is happy, so let's do this.

xjm’s picture

Status: Reviewed & tested by the community » Fixed

Yay for removing dead(ish) code!

I considered whether this would need a change record, but I think not since they will just fall back to the parent implementation if someone was subclassing this, and they're protected methods.

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed and pushed to 8.0.x. Thanks!

  • xjm committed 2c7dc8f on 8.0.x
    Issue #2527406 by Gábor Hojtsy, Berdir: CommentForm::init() and...
Gábor Hojtsy’s picture

Issue tags: -sprint

Yay less code!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.