See parent issue for details.

CommentFileSizeAuthor
#2 jsdoc_filter_module-2525436-2.patch2.45 KBeiriksm
#1 jsdoc_filter_module-2525436-1.patch1.33 KBeiriksm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS commented
Status: Active » Needs review
FileSize
jsdoc_filter_module-2525436-1.patch1.33 KB
eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS commented
FileSize
jsdoc_filter_module-2525436-2.patch2.45 KB

Oh snap, I overlooked one file.

Just another reason why js files should live in js folder I guess ;)

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: jsdoc_filter_module-2525436-2.patch, failed testing.

Status: Needs work » Needs review

nod_ queued 2: jsdoc_filter_module-2525436-2.patch for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed b1d31da on 8.0.x 
    Issue #2525436 by eiriksm, nod_: JSDoc filter module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.