Problem/Motivation

During the usability study, some participants were confused by the settings for the 'taxonomy term' field type. The "Vocabularies" options looked related to the "Create referenced entities if they don't exist" option. They also struggled to understand the meaning of the "Vocabularies" options.

Proposed resolution

Differentiate multiple checkboxes and singular checkboxes when they appear near each other (Needs design exploration)
Re-label the "Vocabularies" option so it's more clear what the meaning is
Move the "Vocabularies" option to the top of the fieldset

Remaining tasks

None.

User interface changes

Changes to the field settings form

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#18 After applying patch 14 without string change- 2522950.png59.15 KBNikitaJain
#18 After applying patch 12 with string change- 2522950.png111.76 KBNikitaJain
#18 Before applying patch - 2522950.png45.76 KBNikitaJain
#14 interdiff-2522950-12-14.txt778 bytespguillard
#14 taxonomy_term_reference_settings_form-2522950-14.patch868 bytespguillard
#14 taxonomy_term_reference_settings_form-2522950-12.patch1.12 KBpguillard
#12 result.png13.08 KBpguillard
#12 taxonomy_term_reference_settings_form-2522950-12.patch1.12 KBpguillard
#7 interdiff-2522950-5-7.txt420 bytespguillard
#7 taxonomy_term_reference_settings_form-2522950-7.patch2.01 KBpguillard
#5 screen-result-with-css-border.png15.95 KBpguillard
#5 interdiff-2522950-1-5.txt1.12 KBpguillard
#5 taxonomy_term_reference_settings_form-2522950-5.patch2.01 KBpguillard
#1 screen.png15.97 KBpguillard
#1 taxonomy_term_reference_settings_form-2522950-1.patch1.82 KBpguillard
dadawd_settings_for_Article___Site-Install.png407.91 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pguillard’s picture

pguillard CreditAttribution: pguillard commented
FileSize
taxonomy_term_reference_settings_form-2522950-1.patch1.82 KB
screen.png15.97 KB

Not a great patch, but often simple things are better...

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Active » Needs review
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Needs review » Needs work

I wouldn't like to introduce a custom element to fix this problem. It feels inconsistent.

pguillard’s picture

pguillard CreditAttribution: pguillard commented

Some specific CSS border would be bad in form.css file.
We can put the auto_create field in a fieldset, hum.
I have no idea

pguillard’s picture

pguillard CreditAttribution: pguillard commented
FileSize
taxonomy_term_reference_settings_form-2522950-5.patch2.01 KB
interdiff-2522950-1-5.txt1.12 KB
screen-result-with-css-border.png15.95 KB

I removed the addition of a custom element, and used some CSS, using a border-top as separator.
What do you think ?

screen-result-with-css-border

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
pguillard’s picture

pguillard CreditAttribution: pguillard commented
FileSize
taxonomy_term_reference_settings_form-2522950-7.patch2.01 KB
interdiff-2522950-5-7.txt420 bytes

Rerolled

pguillard’s picture

pguillard CreditAttribution: pguillard commented
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Status: Needs review » Needs work

@pguillard I don't think it's a bad idea. I'm not sure about adding a new visual component that we haven't used elsewhere before. I'm trying to move away from modules overriding styling changes on individual pages, rather than just using the toolkit of components that Seven provides.

What if we just move that checkbox below the "reference method" field? That would separate them.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review

I guess we can't separate the 2 checkboxes that belong to the same list.
This is why I tried with CSS.

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Needs work

I agree with @LewisNyman, let's just move the auto-create checkbox above the bundle selection form element.

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Needs work » Needs review
FileSize
taxonomy_term_reference_settings_form-2522950-12.patch1.12 KB
result.png13.08 KB

It is easier now (The code has changed a lot!).
This is a totally new patch, without interdiff then.

This gives :
Taxonomy reference display

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented 
+++ b/core/modules/taxonomy/src/Plugin/EntityReferenceSelection/TermSelection.php
@@ -39,10 +39,11 @@ public function entityQueryAlter(SelectInterface $query) {
-    $form['target_bundles']['#title'] = $this->t('Vocabularies');
+    $form['target_bundles']['#title'] = $this->t('Available Vocabularies');

Can we change user facing strings now? Aren't we in string freeze?

pguillard’s picture

pguillard CreditAttribution: pguillard commented
FileSize
taxonomy_term_reference_settings_form-2522950-12.patch1.12 KB
taxonomy_term_reference_settings_form-2522950-14.patch868 bytes
interdiff-2522950-12-14.txt778 bytes

Hum, you are right ! Depend if we keep this in 8.0.x or for 8.1.x ?
I guess this string improvement is not so important. I removed it.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Version: 8.0.x-dev » 8.1.x-dev

As a UI change, this is a minor version target.

Edit: And as such, we can include string changes if we agree they are part of the best fix. Reference: https://www.drupal.org/core/d8-allowed-changes#minor

pguillard’s picture

pguillard CreditAttribution: pguillard commented
Issue tags: -UMN 2015
pguillard’s picture

pguillard CreditAttribution: pguillard commented

#12 is still available with the string change.

NikitaJain’s picture

NikitaJain CreditAttribution: NikitaJain commented
Status: Needs review » Reviewed & tested by the community
FileSize
Before applying patch - 2522950.png45.76 KB
After applying patch 12 with string change- 2522950.png111.76 KB
After applying patch 14 without string change- 2522950.png59.15 KB

Tested and verified the recent patch "taxonomy_term_reference_settings_form-2522950-12.patch" and taxonomy_term_reference_settings_form-2522950-14.patch both are working fine.
After applying the patch - 2522950-12 , "Create referenced entities if they don't exist" this option appears above the "Vocabularies" option. The string change from "Vocabularies" to "Available vocabularies".
For patch - 2522950-14: Same result without the string change. So now its easy to make out the settings for the 'taxonomy term' field type.
Screenshots attached.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

We could commit the weight-only change to 8.0.x, but it's not a functional bug as-such so leaving as is for now.

  • catch committed f3f7e43 on 8.1.x 
    Issue #2522950 by pguillard, LewisNyman: Taxonomy term reference...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.