Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
*** Commit message ***
git commit -m 'Issue #2522652 by neclimdul, phenaproxima: Add getTemplateByName method to TemplateStorage'
Committers: @prajaankit's patch in #8 is not RTBC. #2529250: User repeatedly uploads confusing patches to issues with no explanation
Problem/Motivation
There is not a method for fetching templates by name which would streamline running individual templates
Proposed resolution
Add a new method for retrieving an individual template.
User interface changes
None
API changes
New method.
Note: makes more sense when considered with #2522600: Remove CMI dependency from Migration Templates
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff-2522652-2-6.txt | 1.56 KB | phenaproxima |
#6 | 2522652-6.patch | 2.74 KB | phenaproxima |
#2 | interdiff.2522652.2.txt | 1.6 KB | neclimdul |
#2 | add_gettemplatebyname-2522652-2.patch | 2.4 KB | neclimdul |
Comments
Comment #1
lostkangaroo CreditAttribution: lostkangaroo commentedVery much in favor of this one, I wonder though if it should contain an error rather then returning NULL on missing templates.
Comment #2
neclimdultests
Comment #3
lostkangaroo CreditAttribution: lostkangaroo commentedTime to push this into the RTBC stack. Now with a test!! I have been running this patch for most of my migrations in the last few days and it has been thoroughly tested.
Comment #4
phenaproximaThis is a blocker for #2530030: Create the migrate builder plugin type.
Comment #5
benjy CreditAttribution: benjy at CodeDrop commentedNULL should be capitals
Our coding standards has this on one line.
Missing function comment.
Comment #6
phenaproximaComment #7
phenaproximaThe previous patch was just minor style fixes, so back to RTBC.
Comment #8
prajaankit CreditAttribution: prajaankit commentedComment #9
phenaproxima@prajaankit, what is your patch adding or removing? All I see are formatting changes. Please post some explanation, and an interdiff.
Comment #10
neclimdul#8 just adds incorrect spacing.
Committers: #6 is RTBC.
Comment #11
neclimdulupdate credit.
Comment #12
phenaproximaComment #13
phenaproximaComment #14
phenaproximaComment #15
phenaproximaComment #16
mikeryanPatch is double-plus good, and blocks (at least) #2530030: Create the migrate builder plugin type and #2522660: Templates Broke migrate-manifest. Should we tag this "Migrate critical"?
Comment #17
phenaproximaIn a word: yes.
Comment #18
phenaproximaComment #19
alexpottCommitted 92965c5 and pushed to 8.0.x. Thanks!