Problem/Motivation

Blocks #2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!), causes 2 test failures there.

Proposed resolution

Invalidate the render cache when the State entry is modified.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#1 2512580-1.patch851 bytesWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2512580-1.patch851 bytes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Seems fine, since this is a test-only scenario. Isn't there a more specific cache that that we could use, though?

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Perhaps we could, but there's little value in doing so.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 99cd5a6 and pushed to 8.0.x. Thanks!

  • alexpott committed 99cd5a6 on 8.0.x 
    Issue #2512580 by Wim Leers: NodeEntityViewModeAlterTest uses State to...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

Thanks! SmartCache issue updated :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.